Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harvescraft 1.12.2 spamming log with fruit tree gen disabled causing lag and ai freezing (starts at line 80560) #431

Open
DJlasp opened this issue Dec 11, 2020 · 3 comments

Comments

@DJlasp
Copy link

DJlasp commented Dec 11, 2020

debug.log

@DJlasp DJlasp changed the title harvescraft spamming log with fruit tree gen disabled causing lag and ai freezing (starts at line 80560) harvescraft 1.12.2 spamming log with fruit tree gen disabled causing lag and ai freezing (starts at line 80560) Dec 11, 2020
@coderepo8593
Copy link

This is the code you are saying is causing lag and ai freezing.

public void generate(Random random, int chunkX, int chunkZ, World world,
                     net.minecraft.world.gen.IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {
    if (!fruitTreeConfigManager.enableFruitTreeGeneration) {
        HarvestCraft.log.debug("disabled fruit tree generation");
        return;
    }

You might want to reconsider your assumption. The only thing this will do is spam the log file. It causes the function to log output and return instantly. I don't see how this could be causing your performance issues. One way you could test your theory out would be to recompile without the logging line and see what happens. I think you would still get slow performance because it is being caused by something else.

Do you have fruit tree generation disabled? I would assume yes since that is the only way this message would be logged.

@SigynLaufeyson
Copy link

I'm having the exact same issue but fruit tree generation has NOT been disabled. Fruit trees are still appearing normally. I am running Dynamic Trees for PHC (just an FYI). I've been playing this world (single player) for months but the problem is recent. I can't figure out what changed since PHC nor Dynamic Trees for PHC have been updated for eons. I tried rolling back to an older version of Dynamic Tress but the problem persists. I can play for about an hour before Java freezes. The debug.log is filled with "[Server thread/DEBUG] [harvestcraft]: disabled fruit tree generation." The errors are logged, per second, ranging from 1 per second to 31 per second.

@mmance
Copy link

mmance commented Jan 6, 2022

I don't know about his lag issue, but I have fruit trees disabled and I get that message 10x a second in my log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants