Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Retry Options for commands pk nodes ping and pk nodes find and notifications #16

Open
CMCDragonkai opened this issue Aug 11, 2023 · 2 comments
Labels
development Standard development r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices

Comments

@CMCDragonkai
Copy link
Member

CMCDragonkai commented Aug 11, 2023

Specification

So primarily the idea here is that one could do this for a few commands where it supports it. The --retry-count will retry something up to a limit, while --retry-interval will be the delay between retries.

At the same time, one must define what it means to retry something. What exceptions are considered retryable... maybe it depends on the command itself. It's not exactly generic.

At any case if this is needed, this needs to rebased and redone due to big changes in PK.

Additional context

Tasks

  1. Put --retry-count, --retry-interval, --retry-multiplier into src/utils/options.ts
  2. Design the sentinel values for each
  3. Default to retrying 0 times, 1000 ms interval and multiplier of 1
  4. Consider the need for a --retry-jitter? - requires review of AWS blogs
@CMCDragonkai
Copy link
Member Author

This #180 (comment) illuminated a possibility of creating --retry-multiplier too.

@CMCDragonkai
Copy link
Member Author

@amydevs

@CMCDragonkai CMCDragonkai changed the title CLI Retry Options for commands pk nodes ping and pk nodes find CLI Retry Options for commands pk nodes ping and pk nodes find and notifications May 6, 2024
@CMCDragonkai CMCDragonkai added the r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices
Development

No branches or pull requests

1 participant