-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polykey-Docs CLI Tutorial: Feature-Launch-Revamp-Fix #52
Comments
So this branch will be mostly repurposed for adding the feature-launch-revamp additions into the new feature-getting-started branch. I already figured out an approach (consulting with ChatGPT and verifying with Amy) and identified the difference in "A", "M" and "D" files b/w both branches. First, I will primarily focus on the "A" documentation-related files from the old branch that will need to be cherry picked (or manually added) into the new branch. To do this, I will clone the repo for the feature-launch-revamp branch. This way i can have 2 instances of VS side-by-side. One with the new branch and one with the old. This way i can also locally deploy both at the same time in order to view the additional files in the old branch and identify if they should in fact be cerry picked into the new branch. I marked this assignment on the standup items as an L. My ETA for this procedure to be completed it by tomorrow morning Sydney time. |
Based on the Summary of Changes
We actually kept all these in the new branch
Understanding the Changes
|
Files added in feature-launch-revamp that are not included in feature-getting-started
|
Excalidraw files should be loaded into excalidraw, then you need to extract out subsections as SVGs, and put them as files, and represent them as nicely readable docs. See how I did this here https://github.com/MatrixAI/Orchestrator/issues/5 - I did it as part of an issue spec, you should do this as part of docs creation. |
I was doing some coding work as well, but you can ignore anything that was not But you should also be tackling the getting started specifically together with any changes you need to synthesise. |
I think i'm done auditing the docs. There were some files and images that i transferred over as well. I am going to reframe from removing any files from the files removed section unless you think its necessary as well. The last thing i need to do is verify that the sidebars.ts is configured correctly and then do checks for the buld to mark the PR ready for review. After you review the additions, I can start incorporating the getting started Epic work.
|
Some of the modifications made under
are somewhat questionable and should be reviewed in the PR I fixed deployment errors. Running the sanity checks now to make PR Ready for review. ETA 10 minutes. |
Reference docs then to be out of date quickly because they really should be autogenerated from the code. We actually do autogenerate via |
So is this the "first task" under #9? |
Tasks
The text was updated successfully, but these errors were encountered: