Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra testing for nodes claims process #242

Closed
joshuakarp opened this issue Sep 21, 2021 · 3 comments
Closed

Add extra testing for nodes claims process #242

joshuakarp opened this issue Sep 21, 2021 · 3 comments
Labels
development Standard development enhancement New feature or request r&d:polykey:core activity 3 Peer to Peer Federated Hierarchy

Comments

@joshuakarp
Copy link
Contributor

joshuakarp commented Sep 21, 2021

Specification

Currently, there only exists a success test (for both client-side and server-side) and a couple of exception tests (for the server-side, in GRPCClientAgent.test.ts). Ideally, this should be extended for all possible exceptions on the server-side, and any other potential problems that can arise during this process. (This was originally omitted due to time constraints - it's slightly tedious and time-consuming to write these larger scale tests.)

Furthermore, it would be worthwhile to further investigate the possibility of mocking the server-side such that we can introduce more granular testing of the client side process.

Additional context

Tasks

  1. Create jest tests for each possible exception in the claims process. This can currently only be done for the server-side (by mocking the client) within GRPCClientAgent.test.ts
  2. Investigate the possibility of mocking the server to produce granular testing for the client-side process (within NodeManager.test.ts/NodeConnection.test.ts)
@CMCDragonkai
Copy link
Member

Any testing of node claim testing should make use of timer mocking as discussed in #274, #264, #243.

@joshuakarp
Copy link
Contributor Author

This is a low priority task for the nodes refactoring process. We already have two basic, happy-path tests for both sides of the nodes claims process. This issue is merely about extending these to include the unhappy paths, and extend the server-side mocking (if possible).

@CMCDragonkai
Copy link
Member

Not relevant anymore, will need to create a new issue if we see some problems.

@CMCDragonkai CMCDragonkai added the r&d:polykey:core activity 3 Peer to Peer Federated Hierarchy label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development enhancement New feature or request r&d:polykey:core activity 3 Peer to Peer Federated Hierarchy
Development

No branches or pull requests

2 participants