-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to search across Disconnected Identities during Social Discovery #330
Comments
Not every identity is always going to be connected… and one should be able to discover disconnected identities using the Another thing is that it just continues and continues and never ends. This is a type of command that benefits from some level of pagination… but stream calls is interesting too. |
For example this is a weird situation:
You can see that I did I think it should search through connected THEN disconnected and just keep going. No need for an extra flag. One may provide a property to tell the end user that this identity is a the global search and isn't part of the your connected identities! |
Super important that the search function is case insensitive! It's important to also mention that Given the idea of STDERR being used for diagnostic messages. It also means that it makes sense that it could be used to tell you if it was successful or not. Not sure. |
Another thing is that when claiming, we often provide the ability to do |
Specification
The
identities search
command was properly implemented in #320, however, it was left incomplete with only the ability to search across connected identities. The intended usage of theidentities search
command is as follows:However, attempting to use the
--disconnected
flag will currently result in theErrorProviderUnimplemented
error being thrown, since we have no way of searching across disconnected identities. Like searching across connected identities, the definition of 'disconnected identities' is provider-specific. Since we currently only support GitHub as a provider, this issue only needs to define disconnected identities (and the implementation for searching across them) for GitHub.Additional context
identities search
command usage: Growing the Gestalt Graph and Implementing Social Discovery #320 (comment)Tasks
Provider
interface to add a method for searching across disconnected identitiesThe text was updated successfully, but these errors were encountered: