Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant events in commit messages #5

Closed
MeanMangosteen opened this issue Sep 24, 2018 · 2 comments
Closed

Redundant events in commit messages #5

MeanMangosteen opened this issue Sep 24, 2018 · 2 comments
Assignees
Labels
development Standard development

Comments

@MeanMangosteen
Copy link
Contributor

As of now, the logs of commit messages are formed with the granularity of filesystem level changes. That is, Polykey logs any events deemed a change of state according to the filesystem, e.g. creation, modification, removal of a file...

But consider the case where a file: foo.txt contains the text:

bar

You can open this file and make no modifications and write the file again; or delete the entire contents, save it, and write bar again. The mtime of file will change and the filesystem will detect this as a change and as a result Polykey will also log this change despite the fact there is no change with respect to a secret's state.

So we need to look into log deltas based on secret/file granularity. Git maintains a cheksums for each file's contents in the working directory, staging area, and repository. It compares the checksums to determine if a file has been modified. Perhaps we can do something similar.

@MeanMangosteen MeanMangosteen self-assigned this Sep 26, 2018
@MeanMangosteen MeanMangosteen added enhancement New feature or request development Standard development and removed enhancement New feature or request labels Sep 26, 2018
@CMCDragonkai
Copy link
Member

I wonder if this is a problem we can solve at a higher level.

If there's no change that we can detect at the higher level, it's just a noop.

On the otherhand what's the harm in allowing this to happen?

@robert-cronin
Copy link
Contributor

Closing on account of migration to gitlab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development
Development

No branches or pull requests

3 participants