Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. Incorrect role="presentation" on image, 2. there is no role associated with area-label='crop photo' #591

Open
sunilrathore24 opened this issue Oct 11, 2023 · 2 comments
Labels

Comments

@sunilrathore24
Copy link

There are 2 accessibility issues present in the latest release

  1. the image (.ngx-ic-source-image) has an incorrect role="presentation", this should be removed
  2. the div(.ngx-ic-cropper) has an area label='crop photo' but there is no role added which is creating a minor issue in accessibility tools

please check the attached screenshot for more details

image

@Mawi137
Copy link
Owner

Mawi137 commented Oct 14, 2023

This was done in a PR by someone else, but I don't know enough about accessibility myself to judge how it should be applied to this component.

There are more elements that got the role="presentation", are they also incorrect?
Any suggestion to what the role should be for the div(.ngx-ic-cropper) ?

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants