-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't load basic spreadsheets created in Google Docs #64
Comments
Hi @grin, thank you for the detailed report, great catch! This is currently blocked by CoreOffice/XMLCoder#101, which is our main dependency. But it should be an easy fix overall. As soon as that PR is merged I'll tag a new XMLCoder release and bump the dependency here, which will fix the reported styles issue. |
@MaxDesiatov Thanks a lot, that was fast! ...and thanks for a great library. |
Fix #64 * Fix decoding of Borders model type * Restore compatibility with previous model types * Fix test after adding Border model type changes
This is now fixed in |
Uh, looking at it more closely now, there's no way that it will be backward compatible, optionality of a few properties will have to change. This means 0.7.0 instead of 0.6.2. |
Version
'~> 0.6.1'
Describe the bug
Error I'm getting when trying to load very basic spreadsheets:
To Reproduce
HelloWorld.xlsx
Blank.xlsx
Attaching two files which fail to load with the below code:
Expected behavior
The files should load and just ignore empty border/font tags similar to this:
<borders count="1"><border/></borders>
<fonts count="2"><font><sz val="10.0"/><color rgb="FF000000"/><name val="Arial"/></font><font/></fonts>
The text was updated successfully, but these errors were encountered: