Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make columns property optional on Worksheet #14

Merged
merged 1 commit into from
Nov 23, 2018
Merged

Conversation

MaxDesiatov
Copy link
Collaborator

As reported in #12, there are worksheets that apparently don't have cols node, which means that columns property on Worksheet should be optional.

@codecov
Copy link

codecov bot commented Nov 23, 2018

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files           4        4           
  Lines         187      187           
=======================================
  Hits          183      183           
  Misses          4        4
Impacted Files Coverage Δ
Sources/CoreXLSX/Worksheet.swift 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 435cc7c...4681911. Read the comment docs.

@MaxDesiatov MaxDesiatov merged commit 1ffde9c into master Nov 23, 2018
@delete-merged-branch delete-merged-branch bot deleted the optional-cols branch November 23, 2018 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant