Add ColumnReference type with new API #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
=======================================
+ Coverage 88.23% 95.23% +7%
=======================================
Files 2 4 +2
Lines 68 126 +58
=======================================
+ Hits 60 120 +60
+ Misses 8 6 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously cell references were stringly-typed allowing a user to create a cell reference with an arbitrary string. This is fixed with an introduction of new types:
CellReferenceandColumnReference.ColumnReferenceis a simple wrapper aroundStringthat guards against empty string and characters that can't be used as column references. Rows don't need a separate type for references as they map neatly toUInt, although API parts that used row references have changed to useUIntinstead ofInt. This is a breaking change that requires a major version bump.