Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose errorContextLength on struct XLSXFile #38

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Conversation

MaxDesiatov
Copy link
Collaborator

@MaxDesiatov MaxDesiatov commented Feb 4, 2019

New version of XMLCoder exposes errorContextLength, which could greatly help with diagnostics. There's now an additional argument with a default value of 0 exposed on XLSXFile initializer.

Resolves #32

@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #38 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   98.18%   98.19%   +0.01%     
==========================================
  Files           5        5              
  Lines         220      222       +2     
==========================================
+ Hits          216      218       +2     
  Misses          4        4
Impacted Files Coverage Δ
Sources/CoreXLSX/CoreXLSX.swift 97.64% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb81c12...e505c36. Read the comment docs.

@MaxDesiatov MaxDesiatov merged commit 19975bc into master Feb 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the error-context branch February 5, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants