Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to check sharedStrings order #44

Merged
merged 4 commits into from
Feb 20, 2019
Merged

Add test to check sharedStrings order #44

merged 4 commits into from
Feb 20, 2019

Conversation

hodovani
Copy link
Contributor

@hodovani hodovani commented Feb 20, 2019 •
edited by MaxDesiatov
Loading

Resolves #42

@hodovani hodovani self-assigned this Feb 20, 2019
@hodovani hodovani requested a review from MaxDesiatov February 20, 2019 16:33
houndci-bot
houndci-bot reviewed Feb 20, 2019
View reviewed changes
Tests/CoreXLSXTests/SharedStrings.swift Show resolved Hide resolved
Tests/CoreXLSXTests/SharedStrings.swift Show resolved Hide resolved
Tests/CoreXLSXTests/SharedStrings.swift Outdated Show resolved Hide resolved
Tests/CoreXLSXTests/SharedStrings.swift Show resolved Hide resolved
Tests/CoreXLSXTests/SharedStrings.swift Show resolved Hide resolved
Tests/CoreXLSXTests/SharedStrings.swift Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 20, 2019 •
edited
Loading

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files           6        6           
  Lines         262      262           
=======================================
  Hits          258      258           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea4997...36dd204. Read the comment docs.

@MaxDesiatov MaxDesiatov changed the title Add test to check sharedString order Add test to check sharedStrings order Feb 20, 2019
@hodovani hodovani merged commit 5e52c49 into master Feb 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the sharingString-test branch February 20, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees

@hodovani hodovani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hodovani @MaxDesiatov @houndci-bot