Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Styles with structs describing styles.xml #46

Merged
merged 5 commits into from
Mar 18, 2019
Merged

Add Styles with structs describing styles.xml #46

merged 5 commits into from
Mar 18, 2019

Conversation

MaxDesiatov
Copy link
Collaborator

@MaxDesiatov MaxDesiatov commented Mar 16, 2019 •
edited
Loading

Resolves #45

@MaxDesiatov MaxDesiatov self-assigned this Mar 16, 2019
@MaxDesiatov MaxDesiatov changed the title Add Styles with structs describing styles.xml Add Styles with structs describing styles.xml (WIP) Mar 16, 2019
@MaxDesiatov MaxDesiatov mentioned this pull request Mar 16, 2019
Closed
@codecov
Copy link

codecov bot commented Mar 16, 2019 •
edited
Loading

Codecov Report

Merging #46 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   98.47%   98.49%   +0.02%     
==========================================
  Files           6        6              
  Lines         262      266       +4     
==========================================
+ Hits          258      262       +4     
  Misses          4        4
Impacted Files Coverage Δ
Sources/CoreXLSX/Worksheet/Worksheet.swift 100% <ø> (ø) ⬆️
Sources/CoreXLSX/Worksheet/CellReference.swift 93.33% <ø> (ø) ⬆️
Sources/CoreXLSX/CoreXLSX.swift 98.3% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b088bb2...ab33847. Read the comment docs.

@MaxDesiatov MaxDesiatov changed the title Add Styles with structs describing styles.xml (WIP) Add Styles with structs describing styles.xml Mar 16, 2019
@MaxDesiatov MaxDesiatov assigned hodovani and unassigned MaxDesiatov Mar 16, 2019
@MaxDesiatov MaxDesiatov merged commit 9cee650 into master Mar 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the styles branch March 18, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@hodovani hodovani hodovani approved these changes

Assignees

@hodovani hodovani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxDesiatov @houndci-bot @hodovani