Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump XMLCoder dependency to 0.8.0 #80

Merged
merged 2 commits into from
Aug 12, 2019
Merged

Bump XMLCoder dependency to 0.8.0 #80

merged 2 commits into from
Aug 12, 2019

Conversation

MaxDesiatov
Copy link
Collaborator

@MaxDesiatov MaxDesiatov commented Aug 9, 2019

Looks like 404 checks reported by pod lib lint are triggered by social_media_url in the podspec, this is now removed to make the checks pass.

@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files           8        8           
  Lines         313      313           
=======================================
  Hits          307      307           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7784039...b518dfb. Read the comment docs.

Copy link
Contributor

@hodovani hodovani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MaxDesiatov
Copy link
Collaborator Author

@hodovani thank you 🙏

@MaxDesiatov MaxDesiatov merged commit 346ab5d into master Aug 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the xmlcoder-bump branch August 12, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants