Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Float32 decoding, add DoubleBox #138

Merged
merged 2 commits into from
Oct 6, 2019
Merged

Fix Float32 decoding, add DoubleBox #138

merged 2 commits into from
Oct 6, 2019

Conversation

MaxDesiatov
Copy link
Collaborator

Resolve #130.

Also make xmlString function a computed property.

@MaxDesiatov MaxDesiatov mentioned this pull request Oct 5, 2019
Closed
@codecov
Copy link

codecov bot commented Oct 5, 2019 •
edited
Loading

Codecov Report

Merging #138 into master will increase coverage by 0.07%.
The diff coverage is 74.6%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage    72.1%   72.17%   +0.07%     
==========================================
  Files          42       43       +1     
  Lines        2373     2401      +28     
==========================================
+ Hits         1711     1733      +22     
- Misses        662      668       +6
Impacted Files Coverage Δ
Sources/XMLCoder/Auxiliaries/Box/Box.swift 100% <ø> (ø) ⬆️
Sources/XMLCoder/Auxiliaries/Box/ChoiceBox.swift 76.92% <0%> (ø) ⬆️
...rces/XMLCoder/Auxiliaries/Box/SingleKeyedBox.swift 50% <0%> (ø) ⬆️
...MLCoder/Decoder/SingleValueDecodingContainer.swift 72.72% <100%> (+2.72%) ⬆️
Sources/XMLCoder/Auxiliaries/Box/DateBox.swift 95.55% <100%> (ø) ⬆️
Sources/XMLCoder/Auxiliaries/Box/DataBox.swift 100% <100%> (ø) ⬆️
Sources/XMLCoder/Auxiliaries/Box/SharedBox.swift 100% <100%> (ø) ⬆️
Sources/XMLCoder/Auxiliaries/Box/DecimalBox.swift 100% <100%> (ø) ⬆️
Sources/XMLCoder/Auxiliaries/Box/UIntBox.swift 100% <100%> (ø) ⬆️
Sources/XMLCoder/Auxiliaries/XMLCoderElement.swift 96.11% <100%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb6dda2...73193cf. Read the comment docs.

@MaxDesiatov MaxDesiatov requested a review from hodovani October 5, 2019 20:03
hodovani
hodovani previously approved these changes Oct 6, 2019
View reviewed changes
Copy link
Contributor

@hodovani hodovani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MaxDesiatov MaxDesiatov requested a review from hodovani October 6, 2019 16:51
@MaxDesiatov MaxDesiatov merged commit 9e680f2 into master Oct 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the double-box branch October 6, 2019 18:38
bwetherfield pushed a commit to bwetherfield/XMLCoder that referenced this pull request Oct 16, 2019
@MaxDesiatov @bwetherfield
Fix Float32 decoding, add DoubleBox (CoreOffice#138)
ee4cdd7 
Resolve CoreOffice#130.

Also make `xmlString` function a computed property.
arjungupta0107 pushed a commit to salido/XMLCoder that referenced this pull request Jun 26, 2020
@MaxDesiatov
Fix Float32 decoding, add DoubleBox (CoreOffice#138)
caf4e27 
Resolve CoreOffice#130.

Also make `xmlString` function a computed property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hodovani hodovani hodovani approved these changes

Assignees

@hodovani hodovani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Float vs Float64=Double not parsing 3.14
2 participants
@MaxDesiatov @hodovani