Clean up XMLStackParser
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
- Coverage 48.74% 48.66% -0.08%
==========================================
Files 28 28
Lines 1629 1644 +15
==========================================
+ Hits 794 800 +6
- Misses 835 844 +9
Continue to review full report at Codecov.
|
MaxDesiatov
requested changes
Dec 21, 2018
There was a problem hiding this comment.
thank you @regexident! lgtm, except a few guard checks that could be grouped together
MaxDesiatov
previously approved these changes
Dec 21, 2018
|
@hodovani do you have any comments or questions about he PR? this can be merged otherwise. |
…nt:namespaceURI:qualifiedName:attributes:)`
|
No question from me, thank you @regexident! |
hodovani
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of mostly migrations from
if lettoguard letas well as other semantics-preserving changed to keep the conditional nesting low and make the control flow clear (i.e. the happy/expected path is the one with the least detours intoiforif letblocks).