Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests and fix error context handling #84

Merged
merged 2 commits into from
Mar 9, 2019
Merged

Improve tests and fix error context handling #84

merged 2 commits into from
Mar 9, 2019

Conversation

MaxDesiatov
Copy link
Collaborator

Fixes #83

@MaxDesiatov MaxDesiatov requested a review from hodovani March 8, 2019 11:34
@MaxDesiatov MaxDesiatov mentioned this pull request Mar 8, 2019
Closed
@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #84 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   74.97%   74.98%   +0.01%     
==========================================
  Files          37       37              
  Lines        1774     1775       +1     
==========================================
+ Hits         1330     1331       +1     
  Misses        444      444
Impacted Files Coverage Δ
Sources/XMLCoder/Auxiliaries/XMLStackParser.swift 93.18% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8616cf...5bbccf2. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 8, 2019 •
edited
Loading

Codecov Report

Merging #84 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   74.97%   74.98%   +0.01%     
==========================================
  Files          37       37              
  Lines        1774     1775       +1     
==========================================
+ Hits         1330     1331       +1     
  Misses        444      444
Impacted Files Coverage Δ
Sources/XMLCoder/Auxiliaries/XMLStackParser.swift 93.18% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8616cf...5bbccf2. Read the comment docs.

@MaxDesiatov MaxDesiatov merged commit 85a4e01 into master Mar 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-error-context branch March 9, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hodovani hodovani hodovani approved these changes

Assignees

@hodovani hodovani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDesiatov @hodovani