Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling on typescript.tsx does not work #124

Closed
pappasam opened this issue Jan 24, 2020 · 2 comments
Closed

Disabling on typescript.tsx does not work #124

pappasam opened this issue Jan 24, 2020 · 2 comments

Comments

@pappasam
Copy link

For me, the option to disable on typescript files has no effect. vim-jsx-pretty still overrides my syntax regions (I'm trying to use peitalin/vim-jsx-typescript#4, which has better support for tsx).

let g:vim_jsx_pretty_disable_tsx = 1

Relevant filetype: typescript.tsx

@pappasam pappasam changed the title Disabling on tsx does not work Disabling on typescript.tsx does not work Jan 24, 2020
@yuezk
Copy link
Collaborator

yuezk commented Jan 26, 2020

Hi @pappasam, it seems not an issue of this plugin, I did add the option to stop loading the syntax highlighting for tsx in this plugin.

if get(g:, 'vim_jsx_pretty_disable_tsx', 0)
finish
endif

Are you using the latest version?

@pappasam
Copy link
Author

@yuezk point well taken. After doing some profiling, it turns out that vim-styled-components was the culprit. It automatically loaded the javascript.vim for all typescript plugins. I'll file an issue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants