Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [2.2-3.0] Incorrectly remapping unmapped array type to mapped type #52

Closed
XiaoPangxie732 opened this issue Feb 8, 2022 · 0 comments
Closed

[BUG] [2.2-3.0] Incorrectly remapping unmapped array type to mapped type #52

XiaoPangxie732 opened this issue Feb 8, 2022 · 0 comments
Assignees
@XiaoPangxie732
Labels
bug Something isn't working
Milestone
3.0.1

Comments

@XiaoPangxie732
Copy link
Member

First appeared:

MinecraftDecompiler/src/main/java/cn/maxpixel/mcdecompiler/asm/MappingRemapper.java

Line 114 in 7a19d07

remappedDescriptor.append(mapToUnmapped(unmappedType.getElementType()));

Now:

MinecraftDecompiler/src/main/java/cn/maxpixel/mcdecompiler/asm/ClassifiedMappingRemapper.java

Line 126 in a73b2a5

return "[".repeat(Math.max(0, unmappedType.getDimensions())) + mapToUnmapped(unmappedType.getElementType());

They all should be mapToMapped instead of mapToUnmapped
@XiaoPangxie732 XiaoPangxie732 added the bug Something isn't working label Feb 8, 2022
@XiaoPangxie732 XiaoPangxie732 added this to the 3.0.1 milestone Feb 8, 2022
@XiaoPangxie732 XiaoPangxie732 self-assigned this Feb 8, 2022
@XiaoPangxie732 XiaoPangxie732 moved this to Todo in MD-Plans Feb 8, 2022
@XiaoPangxie732 XiaoPangxie732 moved this from Todo to In Progress in MD-Plans Feb 8, 2022
Repository owner moved this from In Progress to Done in MD-Plans Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XiaoPangxie732 XiaoPangxie732

Labels
bug Something isn't working
Projects
MD-Plans
Status: Done
Milestone
3.0.1
Development

No branches or pull requests
1 participant
@XiaoPangxie732