Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give an option to run the game fullscreen #19

Closed
Mayank0255 opened this issue Oct 27, 2021 · 5 comments · Fixed by #23 or #53
Closed

Give an option to run the game fullscreen #19

Mayank0255 opened this issue Oct 27, 2021 · 5 comments · Fixed by #23 or #53

Comments

@Mayank0255
Copy link
Member

No description provided.

@lyu4321
Copy link
Contributor

lyu4321 commented Oct 30, 2021

Hey @Mayank0255, I'd like to work on this issue. Could you assign it to me?

@Mayank0255
Copy link
Member Author

@lyu4321 go ahead, I just wanna tell you that after the screen is fullscreen the the aspect ratio of the screens should be the same and the extra space on both the side should be blank, or the screen will become very big and it would take a lot of time to reach from one end of the screen to another

@Mayank0255
Copy link
Member Author

@lyu4321 to get the pr counted for the fest you will need to get it merged by the end of tomorrow, so I recommend speed it up so that I can review it asap and merge it if it's good enough and btw after that a special mention will also be done on twitter via my personal account

@lyu4321
Copy link
Contributor

lyu4321 commented Oct 31, 2021

@Mayank0255 Thank you! I've created a PR for this issue.

@Mayank0255
Copy link
Member Author

@lyu4321 thanks will just take a look

Mayank0255 added a commit that referenced this issue Oct 31, 2021
feat(#19): Add support for toggle full screen mode
Mayank0255 added a commit that referenced this issue Oct 31, 2021
@Mayank0255 Mayank0255 reopened this Jan 21, 2022
@Mayank0255 Mayank0255 linked a pull request Feb 5, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants