Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend]: Add Spinners To All Actionable Buttons #85

Open
Mayank0255 opened this issue Jul 1, 2022 · 22 comments
Open

[Frontend]: Add Spinners To All Actionable Buttons #85

Mayank0255 opened this issue Jul 1, 2022 · 22 comments
Assignees
Labels
enhancement Improvement in an existing feature or expanding a feature feature New feature hacktoberfest

Comments

@Mayank0255
Copy link
Owner

Mayank0255 commented Jul 1, 2022

Add spinners to all buttons so that when the user clicks a button, it shows a spinner and the user gets to know that some process is going on

@Mayank0255 Mayank0255 added enhancement Improvement in an existing feature or expanding a feature feature New feature labels Jul 1, 2022
@shravankumar-fs
Copy link

Hey Mayank
Could you assign this to me? I'd like to assist on this?

Also can i use this without setting up the backend locally?

@Mayank0255
Copy link
Owner Author

@shravankumar-fs
Actually backend would be required, otherwise from where will you be getting all the data and test properly.

Let me know if you are in to take up this issue, will assign it to you then

@Mayank0255
Copy link
Owner Author

And this might help for loading buttons,
https://stackoverflow.design/product/components/buttons/#loading

@Mayank0255
Copy link
Owner Author

@shravankumar-fs

Found a workaround to avoid setting up backend,
Can just change the url here to this https://stackoverflow-clone-backend.herokuapp.com

Let me know if you are interested and would want me to assign it to you

@shravankumar-fs
Copy link

Hi @Mayank0255
Please assign it to me, I'll do.

Also currently which buttons need this feature?

I see some places with no action event being triggered

@Mayank0255
Copy link
Owner Author

@shravankumar-fs
Ya sure, go ahead.

So, spinners will be required wherever an api call is going, like when the components of a page are loading, when you click on a button, etc.

Just explore the codebase add spinners wherever you think is required

@Mayank0255
Copy link
Owner Author

@shravankumar-fs Any progress on this?

@amreekminocha
Copy link

Hi.. is anyone working on this issue..
I would like to work on it if no one else is assigned.

@Mayank0255
Copy link
Owner Author

@amreekminocha
Ya sure, go ahead.

Any idea how much time will it take you to complete this task?

@amreekminocha
Copy link

Thanks for assigning..
I'll go through the project once then i'll tell you the required time

@mayank-zoman
Copy link

Thanks for assigning.. I'll go through the project once then i'll tell you the required time

Sure, not an issue

@amreekminocha
Copy link

Hi I am having this error
Stackoverflow-Clone-Frontend/node_modules/webpack-dev-server/lib/Server.js:348
} catch {

Can you help

@Mayank0255
Copy link
Owner Author

@amreekminocha

Can you pls send me the complete error? I can't firgure out anything from this.

And can you please let me know that did you get this error while setting up the repo or what?

@amreekminocha
Copy link

Yes.. I am getting this error while setting the frontend repo
Screenshot 2022-09-29 at 2 45 32 PM

@amreekminocha
Copy link

amreekminocha commented Sep 29, 2022

Hi do share a point of contact as well

@Mayank0255
Copy link
Owner Author

Hi do share a point of contact as well

sure, you can reach out to me on discord https://discords.com/bio/p/mayank0255

@Mayank0255
Copy link
Owner Author

Yes.. I am getting this error while setting the frontend repo Screenshot 2022-09-29 at 2 45 32 PM

Can you try installing react-scripts individually and then starting the server?

npm i react-scripts

@Mayank0255
Copy link
Owner Author

@amreekminocha and check on which node version are in currently?
It should be above 14, 16 is recommended

@amreekminocha
Copy link

This worked.. thanks

@amreekminocha
Copy link

Hi Can you share the buttons where the spinner is require

@Mayank0255
Copy link
Owner Author

Hi Can you share the buttons where the spinner is require

So, spinners will be required wherever an api call is going, like when the components of a page are loading, when you click on a button, etc.

Just explore the codebase add spinners wherever you think is required

It's ok if you miss some places

@Mayank0255
Copy link
Owner Author

@amreekminocha how's the progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement in an existing feature or expanding a feature feature New feature hacktoberfest
Projects
None yet
Development

No branches or pull requests

4 participants