Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename brandPlot to add_logo #45

Open
spencerpease opened this issue May 2, 2019 · 0 comments
Open

Rename brandPlot to add_logo #45

spencerpease opened this issue May 2, 2019 · 0 comments
Labels
enhancement New feature or request Refactor Make the code base cleaner with minimal change to functionality
Milestone
PWFSLSmokePlots 0.6

Comments

@spencerpease
Copy link
Contributor

Description

The name brandPlot is misleading in that you think the function will produce its own plot, when instead it simply adds an image to an already existing plot. A name like add_logo or add_watermark is more descriptive of what the function does.
@spencerpease spencerpease added enhancement New feature or request Refactor Make the code base cleaner with minimal change to functionality labels May 2, 2019
@spencerpease spencerpease added this to the PWFSLSmokePlots 0.6 milestone May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Refactor Make the code base cleaner with minimal change to functionality
Projects
None yet
Milestone
PWFSLSmokePlots 0.6
Development

No branches or pull requests
1 participant
@spencerpease