Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lcov.sh in PSA Crypto repo #41

Closed
davidhorstmann-arm opened this issue Sep 7, 2023 · 1 comment · Fixed by #87
Closed

Use lcov.sh in PSA Crypto repo #41

davidhorstmann-arm opened this issue Sep 7, 2023 · 1 comment · Fixed by #87
Assignees
@tom-daubney-arm
Labels
enhancement New feature or request size-s Estimated task size: small (~2d)

Comments

@davidhorstmann-arm
Copy link
Contributor

Generating coverage data in the Mbed TLS repo is done by the script lcov.sh. In the PSA Crypto repo it is currently done inline in the lcov target in CMake.

It would be best to unify these two approaches by using the lcov.sh script in PSA Crypto. However, this script cannot be used directly in PSA Crypto as it refers to the library directory, which is unique to Mbed TLS.

This task consists of 2 parts:

  1. Modify lcov.sh so that it works in either the Mbed TLS or PSA Crypto repo.
  2. Add lcov.sh to the PSA Crypto repo and use it in the CMake lcov target.
@ronald-cron-arm ronald-cron-arm added enhancement New feature or request size-s Estimated task size: small (~2d) labels Oct 5, 2023
@tom-daubney-arm tom-daubney-arm mentioned this issue Oct 19, 2023
Merged
3 tasks
@ronald-cron-arm ronald-cron-arm linked a pull request Nov 7, 2023 that will close this issue
Add lcov Script Support in CMake Files #87
Merged
@ronald-cron-arm ronald-cron-arm mentioned this issue Nov 9, 2023
Closed
@ronald-cron-arm
Copy link
Contributor

Done in #87

@ronald-cron-arm ronald-cron-arm mentioned this issue May 7, 2024
Closed
@github-project-automation github-project-automation bot moved this to PSA repo Q4 - all.sh components in Backlog for Mbed TLS Aug 30, 2024
@mpg mpg mentioned this issue Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tom-daubney-arm tom-daubney-arm

Labels
enhancement New feature or request size-s Estimated task size: small (~2d)
Projects
Backlog for Mbed TLS
Status: PSA repo Q4 - all.sh components
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add lcov Script Support in CMake Files tom-daubney-arm/TF-PSA-Crypto
3 participants
@ronald-cron-arm @davidhorstmann-arm @tom-daubney-arm