Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-PSA-Crypto first all.sh component #40

Closed
ronald-cron-arm opened this issue Aug 3, 2024 · 1 comment
Closed

TF-PSA-Crypto first all.sh component #40

ronald-cron-arm opened this issue Aug 3, 2024 · 1 comment
Labels
enhancement New feature or request size-s Estimated task size: small (~2d)

Comments

@ronald-cron-arm
Copy link
Contributor

ronald-cron-arm commented Aug 3, 2024

The all.sh script has already been through some changes to be used in the TF-PSA-Crypto repository. It contains in_(mbedtls|tf_psa_crypto)_repo() functions that are used to execute mbedtls/TF-PSA-Crypto specific shell commands.

Depends on all.sh being in the framework, covered by Mbed-TLS/mbedtls#9636.
Following the merge of Mbed-TLS/mbedtls#9445, the all.sh component test_cmake_tf_psa_crypto_out_of_source() has to be moved to a tf-psa-crypto/tests/components-*.sh file.

When executing this component as part of mbedtls CI, the working directory must be tf-psa-crypto (not the root of mbedtls as it is currently the case in Mbed-TLS/mbedtls#9445) as if all.sh for running that component was called from the tf-psa-crypto directory. That way we can remove the change to the tf-psa-crypto directory in the component code and the component code and execution are as if we were in the TF-PSA-Crypto directory. To do that we may need to change the CI script calling the components of all.sh?

Depends on: Mbed-TLS/mbedtls#9445, Mbed-TLS/mbedtls#9636.

@ronald-cron-arm ronald-cron-arm added the enhancement New feature or request label Aug 3, 2024
@ronald-cron-arm ronald-cron-arm moved this to Mbed TLS framework in Mbed TLS Epics Aug 3, 2024
@ronald-cron-arm ronald-cron-arm moved this from Mbed TLS framework to Repository split in Mbed TLS Epics Sep 20, 2024
@ronald-cron-arm ronald-cron-arm added the size-s Estimated task size: small (~2d) label Sep 20, 2024
@ronald-cron-arm ronald-cron-arm changed the title all.sh miscellaneous for repo split TF-PSA-Crypto first all.sh component Sep 20, 2024
@ronald-cron-arm
Copy link
Contributor Author

Done in Mbed-TLS/mbedtls#9720.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size-s Estimated task size: small (~2d)
Projects
Status: Repository split
Development

No branches or pull requests

1 participant