Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify record reading in ssl_parse_client_hello() #4224

Open
mpg opened this issue Mar 12, 2021 · 4 comments
Open

Simplify record reading in ssl_parse_client_hello() #4224

mpg opened this issue Mar 12, 2021 · 4 comments
Labels

Comments

@mpg
Copy link
Contributor

mpg commented Mar 12, 2021

As a follow-up to #4156 which removes support for parsing SSLv2 ClientHello messages, we can now finally get rid of custom record reading in ssl_parse_client_hello() and instead use mbedtls_ssl_read_record() like all other ssl_parse_xxx() functions.

Expected benefits: small code size gain, better maintainability, and more importantly, unblock MPS work.

@hanno-becker
Copy link

This should be done before #4823

@ronald-cron-arm
Copy link
Contributor

I've moved it to the 3.x as I believe this is not related or necessary for the TLS 1.3 implementation.

@mpg
Copy link
Contributor Author

mpg commented Dec 12, 2022

I'm not sure if where we track MPS work, but perhaps this could be put there as well? I don't know all the details, but I'd be surprised if this wasn't a pre-requisite for moving to MPS, as this is about removing a layering violation.

@mpg
Copy link
Contributor Author

mpg commented May 12, 2023

Note: what's the impact in terms of allocating state when we receive a fragmented ClientHello? What do we want to happen in this case? See second point here: #7549 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants