Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSA-PSS sign 1: PK #5711

Closed
3 tasks
mpg opened this issue Apr 8, 2022 · 2 comments · Fixed by #5728
Closed
3 tasks

RSA-PSS sign 1: PK #5711

mpg opened this issue Apr 8, 2022 · 2 comments · Fixed by #5728
Assignees
Labels
enhancement size-s Estimated task size: small (~2d)

Comments

@mpg
Copy link
Contributor

mpg commented Apr 8, 2022

Opaque RSA keys introduced in #5625 can only do PKCS#1v1.5 signatures, with mbedtls_pk_sign(). This task is to extend them to also support PSS signatures, with mbedtls_pk_sign_ext() (introduced in #5559).

  • Change mbedtls_wrap_as_opaque() so that it allow both algorithms.
  • Extend mbedtls_pk_sign_ext() to work with an opaque key.
  • Make sure it's tested, either by extending the existing ,pk_psa_sign_ext() or writing a new one, as is more convenient.

Depends on: #5625
Follow-up: #5712

@mpg mpg added enhancement Product Backlog size-s Estimated task size: small (~2d) labels Apr 8, 2022
@mpg mpg changed the title RSA-PSS signing 1: PK RSA-PSS sign 1: PK Apr 8, 2022
@superna9999 superna9999 self-assigned this Apr 11, 2022
@superna9999
Copy link
Contributor

@mpg is it required to also implement/test verify_ext with an Opaque key?

@superna9999 superna9999 mentioned this issue Apr 12, 2022
1 task
@mpg
Copy link
Contributor Author

mpg commented Apr 12, 2022

Nope, currently we only aim to support private-key operations with opaque keys. (Doing public-key operations with Opaque key pairs, or implementing Opaque public keys, may be useful at some point, but that's much less of a priority.)

@mpg mpg mentioned this issue Apr 21, 2022
2 tasks
@mpg mpg closed this as completed in #5728 Apr 21, 2022
@superna9999 superna9999 mentioned this issue Apr 22, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement size-s Estimated task size: small (~2d)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants