Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for PK parsing of keys using compressed points #6886

Closed
mpg opened this issue Jan 6, 2023 · 1 comment · Fixed by #6937
Closed

Add test for PK parsing of keys using compressed points #6886

mpg opened this issue Jan 6, 2023 · 1 comment · Fixed by #6937
Assignees
@valeriosetti
Labels
enhancement size-s Estimated task size: small (~2d)

Comments

@mpg
Copy link
Contributor

mpg commented Jan 6, 2023

Suggested enhancement

Following #6282 that added support for reading compressed points in ECP, the PK parse module is supposedly able to read EC keys with compressed points in them. However, that is not tested. This task is to add tests for that.

Note: keys with compressed points can be generated with OpenSSL using -conv_form compressed, see the second answer to this SO question.

Justification

Mbed TLS needs this because everything that's supposed to work needs to be tested.
@mpg mpg added enhancement size-s Estimated task size: small (~2d) labels Jan 6, 2023
@mpg mpg mentioned this issue Jan 6, 2023
Merged
3 tasks
@Neustradamus
Copy link

To follow.

@valeriosetti valeriosetti self-assigned this Jan 16, 2023
@valeriosetti valeriosetti mentioned this issue Jan 16, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valeriosetti valeriosetti

Labels
enhancement size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test for PK parsing of keys using compressed points valeriosetti/mbedtls
3 participants
@mpg @Neustradamus @valeriosetti