-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Driver-only ECC: all three top-level modules #7272
Comments
In the current implementation I'm working on, I removed all the previous ECDSA/ECDH/ECJPAKE single cases, because it seemed to me that trying to address all possible combinations of the 3 in |
I don't think we need to test all possible combinations either in all.sh or in depends.py. I'm inclined to keep only 3 components (plus one reference component):
In particular, I think we can remove the component I added recently in #7192 as it's superseded by the new I'm not 100% sure about this plan, but IIUC that's roughly what you've done so far? The thing is we want to find a balance, test enough combinations without using too many CI resources. My idea is for the most costly tests ( Wdyt? |
Context: see #6839
Once TL.ecdsa, TL.ecdh and TL.ecjpake have been achieved though previous tasks, it's time to turn to the full TL: all three modules accelerated at once. This will materialize in a new
all.sh
componentcomponent_test_psa_crypto_config_accel_ecc_use_psa
(plus its reference companion). Add it and fix any issue that may arise (labeled size-m for the uncertainty, but it might turn out that there are no issues and this is really an S).Once this component is added, the previous components
accel_{ecdsa,ecdh,ecjapke}_use_psa
can probably be removed, or at least changed to all use the same reference component. We should strive for a balance between test coverage and use of CI resources which tend to be limited.Edit: also address remaining review comments from #7192 while at it.
The text was updated successfully, but these errors were encountered: