Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hack_dependency_not_implemented #7952

Open
gilles-peskine-arm opened this issue Jul 18, 2023 · 0 comments
Open

Remove hack_dependency_not_implemented #7952

gilles-peskine-arm opened this issue Jul 18, 2023 · 0 comments
Labels
component-test Test framework and CI scripts enhancement priority-medium Medium priority - this can be reviewed as time permits size-s Estimated task size: small (~2d)

Comments

@gilles-peskine-arm
Copy link
Contributor

In generate_psa_tests.py (if not moved or renamed by the implementation of #7845 by the time you read this), there is a function hack_dependencies_not_implemented which skips symbols for which dependencies are not available.

At this point, all PSA_WANT symbols are implemented, so this function is no longer necessary. However, it still triggers on test cases that are enumerated for algorithms/curves/… that we don't implement, and we may want to handle those specially. That should not be based on some fragile parsing, however: we should have a whitelist of non-implemented algorithms somewhere, and make sure that for those algorithms we generate a “not supported” test case.

@gilles-peskine-arm gilles-peskine-arm added enhancement size-s Estimated task size: small (~2d) component-test Test framework and CI scripts priority-medium Medium priority - this can be reviewed as time permits labels Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-test Test framework and CI scripts enhancement priority-medium Medium priority - this can be reviewed as time permits size-s Estimated task size: small (~2d)
Projects
Status: No status
Development

No branches or pull requests

1 participant