Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleLogin SSO #754

Closed
codenyte opened this issue May 1, 2024 · 7 comments · Fixed by #762
Closed

SimpleLogin SSO #754

codenyte opened this issue May 1, 2024 · 7 comments · Fixed by #762
Labels
enhancement New feature or request pr pending An associated pull request is pending approval

Comments

@codenyte
Copy link

codenyte commented May 1, 2024

Is your feature request related to a problem? Please describe.
The current SSO options, Google and GitHub aren't very privacy friendly. A private alternative would be great.

Describe the solution you'd like
Sign in with SimpleLogin (SIWSL)

Describe alternatives you've considered
N/A

Additional context
Screenshot of a forum that implements SIWSL:

@codenyte codenyte added the enhancement New feature or request label May 1, 2024
@ghost ghost mentioned this issue May 3, 2024
@ghost ghost added the pr pending An associated pull request is pending approval label May 3, 2024
@ghost
Copy link

ghost commented May 3, 2024

@codenyte i made a PR for this, wouldn't mind someone else testing it out. i checked it in dev and everything seems to work.

#762

@codenyte
Copy link
Author

codenyte commented May 4, 2024

Thank you very much for the quick response and implementation, but I'm not quite sure how to test this. The README says:

Developer server explained (see "Developers" section down below)

But I couldn't find a "Developers" section below. Could you give me some quick instructions on how to set this up, so I can test it?

@ghost
Copy link

ghost commented May 4, 2024

Thank you very much for the quick response and implementation, but I'm not quite sure how to test this. The README says:

Developer server explained (see "Developers" section down below)

But I couldn't find a "Developers" section below. Could you give me some quick instructions on how to set this up, so I can test it?

Good catch, it should point to this: https://docs.joinmbin.org/contributing/developement_server (or https://docs.joinmbin.org/contributing/development_server... we're in the middle of fixing the typo in the URL)

If you're not familiar with running a kbin/Mbin server, we can wait until #654 is merged (I've been testing on kbin.run), then I can load up #762

@codenyte
Copy link
Author

codenyte commented May 4, 2024

If you're not familiar with running a kbin/Mbin server

I could probably figure it out, but as far as I can see, it requires a Linux host. I currently only have a macOS machine available (I could try a VM but it would probably cause some issues because of the CPU architecture difference x86_64/arm64).

I've been testing on kbin.run

Nice, kbin.run is actually the instance I use :)

@ghost ghost closed this as completed in #762 May 14, 2024
@codenyte
Copy link
Author

codenyte commented May 14, 2024

Thanks for implementing this! There's just one tiny thing I would change: Currently, the SIWSL option just seems to use a generic icon, maybe this icon from Simple Icons could be added? It's licensed under CC0.

@ghost
Copy link

ghost commented May 14, 2024

Thanks for implementing this! There's just one tiny thing I would change: Currently, the SIWSL option just seems to use a generic icon, maybe this icon from Simple Icons could be added? It's licensed under CC0.

I made a PR for this: #781

@codenyte
Copy link
Author

Awesome!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pr pending An associated pull request is pending approval
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant