Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.1] Mod's block tags not working due to depluralizing of tag folder names #669

Open
morriswmz opened this issue Jan 6, 2025 · 1 comment

Comments

@morriswmz
Copy link

Using a fresh 1.21.1 instance with only the lost cities mod installed, I noticed the stairs are not rotated correctly. In the F3 screen the #lostcities:rotatable tag is also missing when looking at a stair block. Using /neoforge tags minecraft:block get lostcities:rotatable also result in unknown tag errors.

Some further investigation reveals that in 1.21 and above, tags/blocks got renamed tags/block: https://github.com/neoforged/.github/blob/main/primers/1.21/index.md#depluralizing-registry-and-tag-folders. However, the generated resources still use the plural folder name here: https://github.com/McJtyMods/LostCities/tree/1.21_neo/src/generated/resources/data/lostcities/tags/blocks, which is why those tags are not loaded by the game.

Renaming tags/blocks to tags/block should fix the issue.

@McJty
Copy link
Collaborator

McJty commented Jan 6, 2025

Thanks for figuring this out. I will fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants