Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenJ9 detection fails for certain builds of the VM #67

Closed
Hubry opened this issue Feb 18, 2021 · 1 comment
Closed

OpenJ9 detection fails for certain builds of the VM #67

Hubry opened this issue Feb 18, 2021 · 1 comment
Labels

Comments

@Hubry
Copy link

Hubry commented Feb 18, 2021

Encountered in vectorwing/FarmersDelight#190, which seems to make the modded game crash because of a typetools bug.

https://github.com/cpw/modlauncher/blob/3cf110cd0b2a5bcd8a44057fd0513e38a4b06f97/src/main/java/cpw/mods/modlauncher/ValidateLibraries.java#L29

The builds used by these users, coming from AdoptOpenJDK seem to contain the string OpenJ9 in properties java.vm.name, java.vm.info and java.vm.vendor, but not the checked java.vendor (which is AdoptOpenJDK).

An answer to a question about detecting OpenJ9 on Adopt's github repo here seems to point at java.vm.name for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants