Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config/Separate item for illegal enchantments #26

Open
Aceplante opened this issue Oct 30, 2023 · 1 comment
Open

Config/Separate item for illegal enchantments #26

Aceplante opened this issue Oct 30, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Aceplante
Copy link

Aceplante commented Oct 30, 2023

There does not seem to be a way to disable illegal levels of enchantments.

The reinforcing chain is a good example of implementation done right. If we dont want the player to be able to obtain illegal levels, we can disable the multiplex chain upgrade, yet leave the regular reinforcing chain. The evil flame is also good as it only allows legal upgrades (which actually seems odd that it doesnt in the context of your mod).

the evil thorn and repulsion gadget on the other hand....

there should either be a config where we can disable illegal level upgrades, or like the reinforcing chain, just have a separate item.

forge 1.18.2

It also only works on diamond items but perhaps that was intentional

@Mechalopa Mechalopa added the enhancement New feature or request label Oct 30, 2023
@Mechalopa
Copy link
Owner

In hmag-forge-mc1.20.1-9.0.6, the enchantment upgrade recipe is now fully JSONized, so this issue has been resolved, but backport possibility is very small...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants