Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav: Refactor - JSX/TSX Good First Issue #77

Open
4 tasks
Medic1111 opened this issue Dec 12, 2022 · 9 comments
Open
4 tasks

Nav: Refactor - JSX/TSX Good First Issue #77

Medic1111 opened this issue Dec 12, 2022 · 9 comments
Assignees
Labels
Client enhancement New feature or request file structure good first issue Good for newcomers help wanted Extra attention is needed JSX/TSX

Comments

@Medic1111
Copy link
Owner

Hey guys... getting there.
The Nav right now is a hot mess. We have 6 components in total Nav related.
Here are things to consider:

  • The FOOTER nav will always display the content of a Logged out Nav
  • The Hamburger Menu content will always match the content of the current Nav (logged in or logged out)
  • The state responsible for checking whether a user is logged in the in the FEATURE/ AUTH CTX/ isAuth (currently set as false)
  • The buttons BUTTON BOX component should still be present as it currently is

The Challenge:

  • Study the current structure and components and find a way to bring compose the functionality in no more than TWO components, maintainability must be present, and Footer nav doesn't count as a component (but could be if wanted)

If you feel like you can tackle that task, please comment below to be assigned to it. Dont forget to read the contributing.md and Open PRs to Development Branch.

Thank you and Happy Collab =)

@Medic1111 Medic1111 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers Client JSX/TSX file structure labels Dec 12, 2022
@coderhersh
Copy link

Hi, there!! Can I Work on this issue??

@Medic1111
Copy link
Owner Author

@coderhersh Its yours! Have fun. If anything, feel free to ask questions here in the comments =)

@coderhersh coderhersh removed their assignment Dec 14, 2022
@Dismated
Copy link

Hi, is the issue still open? Can I take it?

@Medic1111
Copy link
Owner Author

@Dismated Absolutely. I see our friend ended up not being able to contribute so Ill make it yours =)
Have Fun!

@Medic1111
Copy link
Owner Author

@Dismated any progress? I just pushed some commits Nav related. Let me know. If you are no longer able to collab please let me know so I can reassign =) Thanks

@JoshiJaimin
Copy link

Is this issue is still available to contribute?
I would like to work in this issue.

@Medic1111
Copy link
Owner Author

@JoshiJaimin Ill transfer this issue to you =)
Thank you so much!

@Medic1111 Medic1111 assigned JoshiJaimin and unassigned Dismated Jan 31, 2023
@Sarthak00007
Copy link

@Medic1111

Is this issue still available to contribute?
I would like to work on this issue.

@Duggi-Niharika-Sai-06
Copy link

I need to work on open source projects as a part of my university course. I am interested to contribute to this problem.

Can you please assign this to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client enhancement New feature or request file structure good first issue Good for newcomers help wanted Extra attention is needed JSX/TSX
Projects
None yet
Development

No branches or pull requests

6 participants