47.14 On-map artillery not allowed to pre-designate autohit hexes when unofficial rule is engaged.

[orcmaul]

Found in Megamek Windows 0.47.14.

When (Unofficial) Allow artillery units on-map to pre-designate autohit hexes is set to true and an artillery equipped unit is deployed on the map at the start of the game the game does not start with a phase for designating autohit hexes. Tested with artillery deploying after the start of the game and issue persists. Off-map artillery working as intended with pre-designating autohit hexes phase.

Repro:
1: Set (Unofficial) Allow artillery units on-map to pre-designate autohit hexes to true.
2: Add a unit with an artillery piece to your side. (I tested with Thor artillery vehicle and Sniper artillery vehicle).
3: Start Game. Game immediately proceeds to deployment phase and regular play continues from there. The phase for pre-designating autohit hexes never occurs.

Speculation:
Because the unit is deploying on-map in the deployment phase the preceding pre-designating phase is not being triggered. Unfortunately, it doesn't happen in subsequent turns either so I guess it's not checking to see if that ever happened.

[sixlettervariables]

Unofficial rules are at the low end of our support structure, so I've tagged this Help Wanted. It is unlikely any of the core team will get to this in the near future, but we always welcome help!

[neoancient]

The problem is in Entity::isEligibleFor(IGame.Phase). The first statement returns false for any unit that's not deployed if it's not the deployment phase. Offboard artillery is considered deployed, so it gets to be eligible for PHASE_SET_ARTYAUTOHEXES.

[neoancient]

PHASE_STARTING_SCENARIO is only used for scenarios and is not used for regular games.

[TenkawaBC]

Thanks Neoancient. I've been digging further at it, but good to know.

[TenkawaBC]

Branch created and pull request submitted with potential fix.

[Windchild292]

Fixed in #2558