Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect availability ratings for Clan electronic warfare equipment #4481

Closed
Saklad5 opened this issue Jun 3, 2023 · 7 comments
Closed
Labels
Bug Data Hammertime.

Comments

@Saklad5
Copy link
Contributor

Saklad5 commented Jun 3, 2023

Environment

MegaMek Version: MekHQ v0.49.13 Development Snapshot
Operating System: Mac
Java Version: 20.0.1

Description

Various pieces of electronic warfare equipment are currently classified as more exotic than they actually are, especially in the Dark Age era.

All references for the following may be found on page 34 of the third printing of Interstellar Operations: Alternate Eras.

Item Current (Incorrect) Actual (Correct)
Active Probe (Clan) X-X-E-D X-E-D-C
Watchdog CEWS X-X-F*-F X-X-F-E
Light Active Probe (Clan) X-X-F-E X-X-E-D
ECM Suite (Clan) X-X-E-D X-E-D-C
@HammerGS HammerGS added Bug Data Hammertime. labels Jun 4, 2023
@HammerGS
Copy link
Member

HammerGS commented Jun 4, 2023

Checking in the misctype these are set correctly. No idea why they are showing wrong in MML

@Saklad5
Copy link
Contributor Author

Saklad5 commented Jun 4, 2023

Can you reproduce it?

@HammerGS
Copy link
Member

HammerGS commented Jun 4, 2023

Yep, I can see it in MML, but the code matches the correct version.

@Saklad5
Copy link
Contributor Author

Saklad5 commented Jun 4, 2023

Yep, I can see it in MML, but the code matches the correct version.

Is it possible the rules for Inner Sphere factions trying to acquire Clan technology are getting applied somehow? That'd result in the discrepancy we're seeing, including the "F*" for the Watchdog CEWS.

@HammerGS
Copy link
Member

HammerGS commented Jun 4, 2023

Got a fix pending that looks like it resolves it.

image

@Saklad5
Copy link
Contributor Author

Saklad5 commented Jun 4, 2023

What was the issue, precisely? Hard to tell from the commit.

@HammerGS
Copy link
Member

HammerGS commented Jun 4, 2023

From what I could see it was using a wrong flag. Once I cleaned that up things started reporting correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Data Hammertime.
Projects
None yet
Development

No branches or pull requests

2 participants