Revert "Removal of Maxcaps via cvar (space-wizards#31437)"

This reverts commit 4b357a3.

Author: Meguneri

Content.Server/Atmos/EntitySystems/GasTankSystem.cs

@@ -17,8 +17,6 @@
 using Robust.Shared.Audio.Systems;
 using Robust.Shared.Containers;
 using Robust.Shared.Random;
-using Robust.Shared.Configuration;
-using Content.Shared.CCVar;
 
 namespace Content.Server.Atmos.EntitySystems
 {
@@ -34,12 +32,10 @@ public sealed class GasTankSystem : EntitySystem
         [Dependency] private readonly UserInterfaceSystem _ui = default!;
         [Dependency] private readonly IRobustRandom _random = default!;
         [Dependency] private readonly ThrowingSystem _throwing = default!;
-        [Dependency] private readonly IConfigurationManager _cfg = default!;
 
         private const float TimerDelay = 0.5f;
         private float _timer = 0f;
         private const float MinimumSoundValvePressure = 10.0f;
-        private float _maxExplosionRange;
 
         public override void Initialize()
         {
@@ -55,12 +51,6 @@ public override void Initialize()
             SubscribeLocalEvent<GasTankComponent, GasAnalyzerScanEvent>(OnAnalyzed);
             SubscribeLocalEvent<GasTankComponent, PriceCalculationEvent>(OnGasTankPrice);
             SubscribeLocalEvent<GasTankComponent, GetVerbsEvent<AlternativeVerb>>(OnGetAlternativeVerb);
-            Subs.CVar(_cfg, CCVars.AtmosTankFragment, UpdateMaxRange, true);
-        }
-
-        private void UpdateMaxRange(float value)
-        {
-            _maxExplosionRange = value;
         }
 
         private void OnGasShutdown(Entity<GasTankComponent> gasTank, ref ComponentShutdown args)
@@ -330,7 +320,7 @@ public void CheckStatus(Entity<GasTankComponent> ent)
 
             var pressure = component.Air.Pressure;
 
-            if (pressure > component.TankFragmentPressure && _maxExplosionRange > 0)
+            if (pressure > component.TankFragmentPressure)
             {
                 // Give the gas a chance to build up more pressure.
                 for (var i = 0; i < 3; i++)
@@ -343,7 +333,10 @@ public void CheckStatus(Entity<GasTankComponent> ent)
 
                 // Let's cap the explosion, yeah?
                 // !1984
-                range = Math.Min(Math.Min(range, GasTankComponent.MaxExplosionRange), _maxExplosionRange);
+                if (range > GasTankComponent.MaxExplosionRange)
+                {
+                    range = GasTankComponent.MaxExplosionRange;
+                }
 
                 _explosions.TriggerExplosive(owner, radius: range);
 

Content.Shared/CCVar/CCVars.cs

@@ -1240,13 +1240,6 @@ public static readonly CVarDef<bool>
         public static readonly CVarDef<float> AtmosHeatScale =
             CVarDef.Create("atmos.heat_scale", 8f, CVar.SERVERONLY);
 
-        /// <summary>
-        /// Maximum explosion radius for explosions caused by bursting a gas tank ("max caps").
-        /// Setting this to zero disables the explosion but still allows the tank to burst and leak.
-        /// </summary>
-        public static readonly CVarDef<float> AtmosTankFragment =
-            CVarDef.Create("atmos.max_explosion_range", 26f, CVar.SERVERONLY);
-
         /*
          * MIDI instruments
          */

Resources/ConfigPresets/WizardsDen/wizardsDen.toml

@@ -38,6 +38,3 @@ see_own_notes = true
 deadmin_on_join = true
 new_player_threshold = 600
 alert.min_players_sharing_connection = 2
-
-[atmos]
-max_explosion_range = 5