Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞]: Some mod breaks the Sheets class and crashes game on world join (If "Supplementaries" AND "Sleep Tight" are installed) #1295

Open
3 tasks done
User4716 opened this issue Dec 26, 2024 · 3 comments
Labels
1.20.1 Minecraft Version bug Something isn't working server related to Server, not Client side.

Comments

@User4716
Copy link

User4716 commented Dec 26, 2024

📌 Soft-Fix for this issue has been found:
Deleting "Sleep Tight" or "Supplementaries" makes the Sheet class not crash the game.

Checklist:

  • Modloader is up to date
  • Every mod in the modpack uses its latest version
  • A clean boot has been performed (Meaning a boot after deleting every file except the mods folder)

Modpack information:

  • 1.20.1 FABRIC v0.16.9
  • supplementaries-1.20-3.1.10
  • moonlight-1.20-2.13.42

Quick Download modpack: https://filetransfer.io/data-package/p43JL4Vy#link


What happened:

  • To reproduce this crash, you need to have Supplementaries, Sleep Tight, and a third unknown mod installed and join a world.

image

Logs:
crash-server.txt
latest.log

Description: Exception in server tick loop

net.mehvahdjukaar.supplementaries.common.utils.VibeChecker$BadModError: Some OTHER mod loaded the Sheets class to early, causing modded banner patterns and sherds textures to not include modded ones.
Refusing to proceed further.
Missing entries: [ResourceKey[minecraft:banner_pattern / sleep_tight:moon]] (mods listed here are NOT the cause of this, merely the ones that got broken because of it)
Check previous forge log lines to find the offending mod.
	at knot//net.mehvahdjukaar.supplementaries.common.utils.VibeChecker.clientStuff(VibeChecker.java:90)
	at knot//net.mehvahdjukaar.supplementaries.common.utils.VibeChecker.checkVibe(VibeChecker.java:42)
	at knot//net.mehvahdjukaar.supplementaries.common.events.ServerEvents.onPlayerLoggedIn(ServerEvents.java:121)
	at knot//net.mehvahdjukaar.supplementaries.common.events.fabric.ServerEventsFabric.lambda$init$0(ServerEventsFabric.java:40)
	at knot//net.fabricmc.fabric.api.networking.v1.ServerPlayConnectionEvents.lambda$static$2(ServerPlayConnectionEvents.java:48)
	at knot//net.fabricmc.fabric.impl.networking.server.ServerPlayNetworkAddon.onClientReady(ServerPlayNetworkAddon.java:66)
	at knot//MC//net.minecraft.server.PlayerManager.handler$fci001$fabric-networking-api-v1$handlePlayerConnection(PlayerManager.java:7518)
	at knot//MC//net.minecraft.server.PlayerManager.onPlayerConnect(PlayerManager.java:215)
	at knot//MC//net.minecraft.server.network.ServerLoginNetworkHandler.addToServer(ServerLoginNetworkHandler.java:131)
	at knot//MC//net.minecraft.server.network.ServerLoginNetworkHandler.md178e08$polymer-networking$lambda$polymerNet$prePlayHandshakeHackfest$0$0(ServerLoginNetworkHandler.java:549)
	at knot//eu.pb4.polymer.networking.impl.EarlyConnectionMagic.lambda$handle$0(EarlyConnectionMagic.java:32)
	at knot//eu.pb4.polymer.networking.api.EarlyPlayNetworkHandler.lambda$onKeepAlive$0(EarlyPlayNetworkHandler.java:108)
	at knot//MC//net.minecraft.server.ServerTask.run(ServerTask.java:18)
	at knot//MC//net.minecraft.util.thread.ThreadExecutor.executeTask(ThreadExecutor.java:156)
	at knot//MC//net.minecraft.util.thread.ReentrantThreadExecutor.executeTask(ReentrantThreadExecutor.java:23)
	at knot//net.minecraft.server.MinecraftServer.executeTask(MinecraftServer.java:782)
	at knot//net.minecraft.server.MinecraftServer.executeTask(MinecraftServer.java:164)
	at knot//MC//net.minecraft.util.thread.ThreadExecutor.runTask(ThreadExecutor.java:130)
	at knot//net.minecraft.server.MinecraftServer.runOneTask(MinecraftServer.java:21818)
	at knot//net.minecraft.server.MinecraftServer.runTask(MinecraftServer.java:758)
	at knot//MC//net.minecraft.util.thread.ThreadExecutor.runTasks(ThreadExecutor.java:139)
	at knot//net.minecraft.server.MinecraftServer.runTasksTillTickEnd(MinecraftServer.java:743)
	at knot//net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:675)
	at knot//net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:265)
	at java.base@17.0.1/java.lang.Thread.run(Thread.java:833)
@User4716 User4716 added the bug Something isn't working label Dec 26, 2024
@github-actions github-actions bot added 1.20.1 Minecraft Version information More Information regarding the issue server related to Server, not Client side. labels Dec 26, 2024
@User4716 User4716 changed the title [🐞]: Ceash on world join (Needs investigation) [🐞]: Crash on world join (Needs investigation) Dec 26, 2024
@User4716
Copy link
Author

Oh I was dumb, the crash report says it right there that "Sleep Tight" has something to do with the crash.
After removing it, the issue went away!

@User4716 User4716 changed the title [🐞]: Crash on world join (Needs investigation) [🐞]: Sleep Tight causes crash on world join Dec 26, 2024
@User4716 User4716 changed the title [🐞]: Sleep Tight causes crash on world join [🐞]: Sleep Tight causes crash on world join if some other unknown mod is present Dec 26, 2024
@User4716
Copy link
Author

User4716 commented Dec 26, 2024

Sleep Tight does not directly cause Supplementaries to crash the game; there needs to be a third (potentially even more) mod(s) in the mix for something to go wrong and for the game to crash

Thankfully this was not a large problem since I can just remove Sleep Tight or Supplementaries and the crash goes away. But the other culprit mod(s) are still unknown, so that's why this issue is still up.

@MehVahdJukaar close this issue if you think it's not worth it to figure out the culprit mod or to talk about this topic anymore

@User4716 User4716 reopened this Dec 26, 2024
@User4716
Copy link
Author

The following GitHub issue seems to be talking about this same issue:

MehVahdJukaar/sleep_tight#81

@User4716 User4716 changed the title [🐞]: Sleep Tight causes crash on world join if some other unknown mod is present [🐞]: Some mod breaks the Sheets class (causing Sleep Tight to crash the game) Dec 26, 2024
@User4716 User4716 changed the title [🐞]: Some mod breaks the Sheets class (causing Sleep Tight to crash the game) [🐞]: Some mod breaks the Sheets class and crashes game on world join (If "Supplementaries" AND "Sleep Tight" are installed) Dec 26, 2024
@Xelbayria Xelbayria removed the information More Information regarding the issue label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20.1 Minecraft Version bug Something isn't working server related to Server, not Client side.
Projects
None yet
Development

No branches or pull requests

2 participants