Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞]: Quark variant chests and ladders not generating for Abnormals wood types #759

Closed
4 tasks done
4thArmoredDev opened this issue Jan 7, 2025 · 7 comments
Closed
4 tasks done
Labels
1.20.1-FORGE Minecraft Version bug Something isn't working
Milestone

Comments

@4thArmoredDev
Copy link

Code of Conduct

  • Always check you are using the latest version of the mods and its dependencies
  • Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue still persists.
  • If you are unsure which mod is the culprit.
    Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
  • Confirm that there is no existing issue with a similar description submitted in the list of issues.

Version - Loader (DO NOT FORGET TO SELECT THE CORRECT VERSION)

1.20.1 - FORGE

EveryCompat Version

everycomp-1.20-2.7.10

Moonlight Lib Version

moonlight-1.20-2.13.46-forge

Issue with mods

atmospheric-1.20.1-6.0.0, autumnity-1.20.1-5.0.1, environmental-1.20.1-4.0.1, upgrade_aquatic-1.20.1-6.0.1, Quark-4.0-460

Issue Detail

Everycompat does not generate Quark variant chests and ladders in Team Abnormals wood types. Variant chests and ladders are generated for other mods, such as Biomes O' Plenty and Oh the Biomes We've Gone. Woodworks is NOT installed, and Quark anti-overlap config is disabled.

Note: this issue did not occur in 1.19.2 (everycomp-1.19.2-2.5.7). All chests and ladders generated properly and had unique textures in that version.

OPTIONAL: Latest.log | Crash-report Attachment

No response

OPTIONAL: To Produce

No response

@4thArmoredDev 4thArmoredDev added the bug Something isn't working label Jan 7, 2025
@github-actions github-actions bot added the 1.20.1-FORGE Minecraft Version label Jan 7, 2025
@Xelbayria
Copy link
Collaborator

Hm I'll port the fix from 1.19.2 to 1.20.1. The fix should allow these chests to be generated with 2 mods: Quark and Abnormals' mods

@4thArmoredDev
Copy link
Author

Thanks! Is there any plan to add the unique chest textures for BoP and Abnormals wood types in 1.20?

@Xelbayria
Copy link
Collaborator

Xelbayria commented Jan 9, 2025

unique chest textures for BoP and Abnormals wood types in 1.20?

can you clarify
Do you mean BoP has chests and EC could support that due its unique texture for chest?

@4thArmoredDev
Copy link
Author

So back in 1.19 I was running Quark, BoP, BYG, and a bunch of Abnormals mods. EC gave unique textures for every chest variant, from all of those mods. Now in 1.20, only the vanilla, Quark, and BWG chests have unique textures. The BoP chests just use the default oak-style textures in the current version.

@4thArmoredDev
Copy link
Author

So to give an example, in 1.19, everycomp:q/biomesoplenty/fir_chest had a unique texture design, but now in 1.20, all q/biomesoplenty chests use the same default texture design. Upon further inspection, I found that while most of the q/biomeswevegone chests have unique texture designs, the newest ones (Florus, Ironwood, and Sakura) do not.

Hope that clarifies things.

@Xelbayria
Copy link
Collaborator

Xelbayria commented Jan 10, 2025

🤔 EveryCompat use the texture of Quark's chest along with texture of WoodTypes from Biomes We've Gone or Biomes O' Plenty to create a texture for chest.

EveryCompat 1.19.2 and 1.20.1 has the same system.


UPDATE:

Apparently, idk why it skipped the chests & ladders from Abnormal's wood mods. I add an exception so they will be generated.

@Xelbayria
Copy link
Collaborator

FIXED in v2.7.11

@Xelbayria Xelbayria added this to the 1.20-2.7.11 milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20.1-FORGE Minecraft Version bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants