Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arabic number to words #71

Closed
wants to merge 12 commits into from
Closed

Arabic number to words #71

wants to merge 12 commits into from

Conversation

faisalr
Copy link
Contributor

@faisalr faisalr commented Feb 2, 2014

Hello

I made a new method called "ToArabicWords" in NumberToWordsExtension.

@MehdiK
Copy link
Member

MehdiK commented Feb 3, 2014

Thanks for the contribution. I have commented on a few bits that I think should be changed before I can pull this in.

@faisalr
Copy link
Contributor Author

faisalr commented Feb 3, 2014

I fixed the pull request with something better than ambient culture, you can pull this in.

@MehdiK
Copy link
Member

MehdiK commented Feb 3, 2014

Thanks for the hard word and for taking the comments in. This is starting to look very exciting. Only two things:

  • Please submit a new PR without the binaries as this one is a bit bulky. I am going to close this one hoping to get the new PR from you based on this one.
  • Please change back to using current culture for consistency amongst localized methods. I also really liked when you implemented the arabic tests in the Localisation folder.

@MehdiK MehdiK closed this Feb 3, 2014
@MehdiK MehdiK mentioned this pull request Feb 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants