Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a crucial "bug" in the way of calculating metrics. #30

Open
zezhishao opened this issue May 10, 2022 · 1 comment
Open

There is a crucial "bug" in the way of calculating metrics. #30

zezhishao opened this issue May 10, 2022 · 1 comment

Comments

@zezhishao
Copy link

zezhishao commented May 10, 2022

Hi, Thanks for your wonderful works~
Recently, I found there seems to be some inconsistency between STFGNN and other baselines (e.g., Graph WaveNet, DCRNN) in the way of calculating metrics, which may make the comparison unfair.
Specifically, most of the baselines calculate the metrics at horizons 3, 6, and 12, while STFGNN seems to calculate the metrics among horizons 1~3, 1~6, and 1~12.
Do I understand the code correctly?

@zezhishao zezhishao changed the title There is a crucial "bugs" in the way of calculating metrics. There is a crucial "bug" in the way of calculating metrics. May 10, 2022
@EEHITer
Copy link

EEHITer commented Jul 10, 2022

Similarly, I also noticed this problem. The author's first version of Arxiv used an average method to compare the performance of the METR-LA and PEMS-BAY datasets among 1-3 , 1-6, and 1-12 , but works such as DCRNN or GraphWaveNet calculate the metrics at horizons 3, 6, and 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants