Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bugs in gsDesign2::check_fail_rate #132

Closed
LittleBeannie opened this issue Dec 22, 2022 · 0 comments · Fixed by #133
Closed

fix bugs in gsDesign2::check_fail_rate #132

LittleBeannie opened this issue Dec 22, 2022 · 0 comments · Fixed by #133
Assignees
@LittleBeannie
Labels
bug Something isn't working

Comments

@LittleBeannie
Copy link
Collaborator

The current version of gsDesign2 gives error when running

gsDesign2:::check_fail_rate(tibble::tibble(duration = c(6, 10), fail_rate = c(0, 1)))

While only 1 number in fail_rate needs to be > 0.
@LittleBeannie LittleBeannie self-assigned this Dec 22, 2022
@LittleBeannie LittleBeannie added the bug Something isn't working label Dec 22, 2022
@LittleBeannie LittleBeannie linked a pull request Dec 22, 2022 that will close this issue
132 fix bugs in gsdesign2check fail rate #133
Merged
@nanxstats nanxstats mentioned this issue Dec 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LittleBeannie LittleBeannie

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

132 fix bugs in gsdesign2check fail rate Merck/gsDesign2
1 participant
@LittleBeannie