Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up summary and as_gt functions #282

Closed
LittleBeannie opened this issue Aug 18, 2023 · 3 comments · Fixed by #461
Closed

Tidy up summary and as_gt functions #282

LittleBeannie opened this issue Aug 18, 2023 · 3 comments · Fixed by #461
Assignees
Labels
best-practice Enhance programming best practice

Comments

@LittleBeannie
Copy link
Collaborator

The summary and as_gt functions in their current state are extremely lengthy. A preferable approach would be to condense them into a shorter function that utilizes sub-functions where necessary.

@LittleBeannie
Copy link
Collaborator Author

Hi @jdblischak , considering we have couple of PRs to improve as_gt and as_rtf (such as #458, #450, #449), can we close this issue? I can create another issue to tidy-up the nested if-else in summary.gs_design in another issue, to make the issue more specific.

@yihui
Copy link
Contributor

yihui commented Aug 29, 2024

Or I can create a PR to clean up the summary functions, and close this issue once that PR is merged.

@LittleBeannie
Copy link
Collaborator Author

Sounds great, thank you, @yihui !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best-practice Enhance programming best practice
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants