Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter to wMB #78

Closed
LittleBeannie opened this issue Oct 28, 2022 · 4 comments
Closed

Add parameter to wMB #78

LittleBeannie opened this issue Oct 28, 2022 · 4 comments
Assignees
@elong0527

Comments

@LittleBeannie
Copy link
Collaborator

To align with simtrial and support the recommendation of Magirr, Dominic. "Non‐proportional hazards in immuno‐oncology: Is an old perspective needed?." Pharmaceutical Statistics 20.3 (2021): 512-527. Sets a maximum weight for a modestly weighted logrank test. Shall we also update the weighting functions?
@elong0527
Copy link
Collaborator

Could you provide the formula to be implemented? Or indicate the formula number in the paper.

@LittleBeannie
Copy link
Collaborator Author

Could you provide the formula to be implemented? Or indicate the formula number in the paper.

Hi Yilong, I haven't got time to take a close look at the paper yet. Will get back to you later.

@LittleBeannie LittleBeannie mentioned this issue Nov 4, 2022
Closed
18 tasks
@nanxstats
Copy link
Collaborator

Keaven's patch for simtrial: Merck/simtrial#22

@nanxstats
Copy link
Collaborator

Fixed by #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elong0527 elong0527

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nanxstats @elong0527 @LittleBeannie