Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API update #25

Closed
59 tasks done
LittleBeannie opened this issue Jan 11, 2023 · 1 comment
Closed
59 tasks done

API update #25

LittleBeannie opened this issue Jan 11, 2023 · 1 comment
Assignees
Labels

Comments

@LittleBeannie
Copy link
Collaborator

LittleBeannie commented Jan 11, 2023

In simtrial, most of the function/variable/argument name follows the camel case (e.g., the enrollRates argument in the simfix function). In modern package development, people follow snake case. For example, enrollRates should be enroll_rate in snake case. The differences between snake case and camal are summarized in https://www.freecodecamp.org/news/snake-case-vs-camel-case-vs-pascal-case-vs-kebab-case-whats-the-difference/.

Function name update:

Arguments to be updated:

Output variable names to be updated in tensurv:

image

Output variable names to be updated in tenFH, tenFH:

Output variable names to be updated in cutData, CutDataAtCount:

Output of pwexpfit:

image

Output of simfix:

Output of simfix2simPWSurv and simPWSurv:

@nanxstats
Copy link
Collaborator

@LittleBeannie Yes, I think it would be the best if we can keep the style consistent. The code linter will detect all style violations, regardless if they are from internal or exported functions. I know it could be a lot of refactoring work, though!

@LittleBeannie LittleBeannie added API and removed development New feature or request labels Jan 28, 2023
@Merck Merck deleted a comment from nanxstats Feb 7, 2023
@LittleBeannie LittleBeannie mentioned this issue May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants