You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@LittleBeannie Yes, I think it would be the best if we can keep the style consistent. The code linter will detect all style violations, regardless if they are from internal or exported functions. I know it could be a lot of refactoring work, though!
In
simtrial
, most of the function/variable/argument name follows the camel case (e.g., theenrollRates
argument in thesimfix
function). In modern package development, people follow snake case. For example,enrollRates
should beenroll_rate
in snake case. The differences between snake case and camal are summarized in https://www.freecodecamp.org/news/snake-case-vs-camel-case-vs-pascal-case-vs-kebab-case-whats-the-difference/.Function name update:
fixedBlockRand
->randomize_by_fixed_block
@lili-ling-msd, seefixedBlockRand
->rand_by_fixed_block
#32cutData
->cut_data_by_date
@XintongLi2023, seecutData
->cut_data_by_date
#33cutDataAtCount
->cut_data_by_event
@XintongLi2023, seecutDataAtCount
->cut_data_by_event
#34getCutDateForCount
->get_cut_date_by_event
@XintongLi2023, seegetCutDateForCount
->get_cut_date_by_event
#35rpwenroll
->rpw_enroll
@lili-ling-msd, seerpwenroll
->rpw_enroll
#36pwexpfit
->fit_pwexp
@lili-ling-msd, seepwexpfit
->fit_pwexp
#37pMaxCombo
->pvalue_maxcombo
@lili-ling-msd, seepMaxCombo
->pvalue_maxcombo
#38tenFH
->wlr
@lili-ling-msd, seetenFH
->wlr
#39tenFHcorr
-> will be merged intowlr
given therg
@LittleBeannietensurv
->counting_process
@lili-ling-msd, seetensurv
->counting_process
#40wMB
->mb_weight
@XintongLi2023 , seewMB
->mb_weight
#41simPWSurv
->sim_pw_surv
? @XintongLi2023, seesimPWSurv
->sim_pw_surv
#42simfix
->sim_fixed_n
? @XintongLi2023, seesimfix
->sim_fixed_n
#43Arguments to be updated:
enrollRates
->enroll_rate
@lili-ling-msd, seeenrollRates
->enroll_rate
andenrollTime
->enroll_time
#44failRates
->fail_rate
, @XintongLi2023, seefailRates
->fail_rate
andfailRate
->fail_rate
andfailTime
->fail_time
#45failRate
->fail_rate
@XintongLi2023, seefailRates
->fail_rate
andfailRate
->fail_rate
andfailTime
->fail_time
#45dropoutRates
->dropout_rate
@lili-ling-msd, seedropoutRates
->dropout_rate
anddropoutRate
->dropout_rate
anddropoutTime
->dropout_time
#46dropoutRate
->dropout_rate
@lili-ling-msd, seedropoutRates
->dropout_rate
anddropoutRate
->dropout_rate
anddropoutTime
->dropout_time
#46sampleSize
->sample_size
@XintongLi2023 , seesampleSize
->sample_size
#47targetEvents
->target_event
@lili-ling-msd, seetargetEvents
->target_event
#48timingType
->timing_type
@XintongLi2023 , seetimingType
->timing_type
#49rg
->rho_gamma
@lili-ling-msd, seerg
->rho_gamma
#50strata
->stratum
@XintongLi2023, seestrata
->stratum
andStratum
->stratum
#51Stratum
->stratum
@XintongLi2023, seestrata
->stratum
andStratum
->stratum
#51Treatment
->treatment
@lili-ling-msd, seeTreatment
->treatment
and"Control"
->"control"
#52"Control"
->"control"
@lili-ling-msd, seeTreatment
->treatment
and"Control"
->"control"
#52"Experimental"
->"experimental"
@lili-ling-msd, seeTreatment
->treatment
and"Control"
->"control"
#52nsim
->n_sim
@XintongLi2023, seensim
->n_sim
#53cutDate
->cut_date
@lili-ling-msd, seecutDate
->cut_date
#54count
->event
incutDataAtCount
andgetCutDateForCount
@XintongLi2023, seecount
->event
incutDataAtCount
andgetCutDateForCount
#55dummyvar
->dummy_var
inpMaxCombo
@lili-ling-msd, seedummyvar
->dummy_var
inpMaxCombo
#56Z
->z
inpMaxCombo
@XintongLi2023 , seeZ
->z
inpMaxCombo
#57Srv
->srv
inpwexpfit
@lili-ling-msd, seeSrv
->srv
inpwexpfit
#58returnVariance
->return_variance
intenFH
@XintongLi2023 , seereturnVariance
->return_variance
intenFH
#59txval
->arm
intensurv
@lili-ling-msd, seetxval
->arm
intensurv
#60wmax
->w_max
inwMB
@XintongLi2023 , seewmax
->w_max
inwMB
#61Output variable names to be updated in
tensurv
:Stratum
->stratum
(assigned to Xintong, same asstrata
->stratum
andStratum
->stratum
#51 )events
->n_event_tol
@LittleBeannie, see update internal variables to follow snake case #28txevents
->n_event_trt
@LittleBeannie, see update internal variables to follow snake case #28atrisk
->n_risk_tol
@LittleBeannie, see update internal variables to follow snake case #28txatrisk
->n_risk_trt
@LittleBeannie, see update internal variables to follow snake case #28S
->s
@LittleBeannieOminusE
->o_minus_e
@LittleBeannie, see update internal variables to follow snake case #28Var
->var_o_minus_e
@LittleBeannie, see update internal variables to follow snake case #28Output variable names to be updated in
tenFH
,tenFH
:Z
->z
(assigned to Xintong, same asZ
->z
inpMaxCombo
#57)V1
->v1
@LittleBeannieOutput variable names to be updated in
cutData
,CutDataAtCount
:Stratum
->stratum
(assigned to Xintong, same asstrata
->stratum
andStratum
->stratum
#51 )Treatment
->treatment
@LittleBeannieOutput of
pwexpfit
:TTOT
->ttot
@LittleBeannie, see update internal variables to follow snake case #28events
->event
@LittleBeannie, see update internal variables to follow snake case #28Output of
simfix
:Events
->event
@LittleBeannielnhr
->ln_hr
@LittleBeannieDuration
->duration
@LittleBeannieSim
->sim
@LittleBeannieOutput of
simfix2simPWSurv
andsimPWSurv
:Staratum
->stratum
(assigned to Xintong, same asstrata
->stratum
andStratum
->stratum
#51)Treatment
->treatment
@LittleBeannieenrollTime
->enroll_time
(assigned to Lili, same asenrollRates
->enroll_rate
andenrollTime
->enroll_time
#44)failTime
->fail_time
(assigned to Xintong, same asfailRates
->fail_rate
andfailRate
->fail_rate
andfailTime
->fail_time
#45)dropoutTime
->dropout_time
(assigned to Lili, same asdropoutRates
->dropout_rate
anddropoutRate
->dropout_rate
anddropoutTime
->dropout_time
#46)The text was updated successfully, but these errors were encountered: