-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vignette to document the different behaviors of coxph variants #290
Comments
Hi @nanxstats and @larry-leon, do you happen to have a timeline to get the vignette published? |
Larry might have an estimate. |
Sorry, I forgot about this.
Can I get a draft by end of next week?
Also, in simtrial, I assume there is not a way to set “timefix” to FALSE for coxph ?
If not, I will just mention the issue, and discuss how the aeqSurv() function can be applied directly
Thanks,Larry
Sent from Yahoo Mail for iPhone
On Thursday, October 24, 2024, 11:59 AM, Nan Xiao ***@***.***> wrote:
Hi @nanxstats and @larry-leon, do you happen to have a timeline to get the vignette published?
Larry might have an estimate.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hi @larry-leon , next week works perfectly. Could you please provide more information of what is "timefix"? |
In coxph.control, timefix=TRUE is default which implements aeqSurv to “resolve any near ties”.
So in order to match how simtrial implements the logrank test, we would need to set timefix=FALSE
However, if the main goal of the vignette is just to raise awareness, then we do not need to revise the coxph call.
Sent from Yahoo Mail for iPhone
On Thursday, October 24, 2024, 1:34 PM, Yujie Zhao ***@***.***> wrote:
Hi @larry-leon , next week works perfectly. Could you please provide more information of what is "timefix"?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Thanks for the clarification! I believe simtrial is |
Thanks @larry-leon for discovering the intriguing difference and kindly agree to contribute the vignette about ties.
The text was updated successfully, but these errors were encountered: