Skip to content
This repository was archived by the owner on Jun 15, 2024. It is now read-only.

Commit 6c2c0fc

Browse files
committed
feat(Android): upgrade to AndroidPdfViewer@2.0.1 with continuous scroll
1 parent 2ff03d8 commit 6c2c0fc

File tree

6 files changed

+8
-20
lines changed

6 files changed

+8
-20
lines changed

AndroidPdfViewer.d.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,5 @@ declare class Configurator {
2121
pages(...pageNumbers: number[]): this;
2222
enableDoubletap(enable: boolean): this;
2323
enableSwipe(enable: boolean): this;
24-
showMinimap(show: boolean): this;
25-
swipeVertical(swipe: boolean): this;
24+
swipeHorizontal(horizontal: boolean): this;
2625
}

README.md

+3-10
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,6 @@ tns platform add ios
4242
tns run ios
4343

4444
# Android
45-
tns platform add android@2.2.0-next-2016-08-02-918
46-
tns run android # try again if you get error "more than one library ..."
47-
```
48-
49-
## Why the dependency on `android@next` platform
50-
51-
I've been getting all kinds of different issues trying to run this plugin with
52-
the latest released version of `tns-core-modules` and `tns-android` runtime, and
53-
the issues don't appear to exist in the current pre-release versions. Therefore
54-
for the time being I've set the dependencies to pre-release versions.
45+
tns platform add android
46+
tns run android
47+
```

demo/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55
"version": "2.2.1"
66
},
77
"tns-android": {
8-
"version": "2.2.0-next-2016-08-02-918"
8+
"version": "2.2.0"
99
}
1010
},
1111
"private": true,
1212
"dependencies": {
13-
"nativescript-pdf-view": "1.0.1",
13+
"nativescript-pdf-view": "file:..",
1414
"tns-core-modules": "2.2.1"
1515
},
1616
"devDependencies": {

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"main": "src/plugin.js",
55
"nativescript": {
66
"platforms": {
7-
"android": "2.2.0-next-2016-08-02-918",
7+
"android": "2.2.0",
88
"ios": "2.2.1"
99
}
1010
},

platforms/android/include.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@ android {
77
}
88

99
dependencies {
10-
compile 'com.github.barteksc:android-pdf-viewer:1.1.2'
10+
compile 'com.github.barteksc:android-pdf-viewer:2.0.1'
1111
}

src/plugin.android.ts

-4
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,6 @@ export class PDFView extends common.PDFView {
3636

3737
this.android
3838
.fromUri(uri)
39-
.enableSwipe(true)
40-
.enableDoubletap(true)
41-
.swipeVertical(true)
42-
.showMinimap(false)
4339
.load();
4440
}
4541

0 commit comments

Comments
 (0)