Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert internal, static colors into color assets. #1301

Closed
austinwright opened this issue Mar 25, 2020 · 1 comment
Closed

Convert internal, static colors into color assets. #1301

austinwright opened this issue Mar 25, 2020 · 1 comment

Comments

@austinwright
Copy link
Contributor

Xcode 9 introduced Color Assets. Now that MessageKit is targeting iOS 11+, we can make use of these color assets and gain their benefits - mainly that color asset (and system defined semantic color) instances automatically adjust to the current environment settings. So if an end-user has their phone set to automatically switch from light to dark mode, currently a framework client would need to refresh the view programatically. This means listening for notifications and other boilerplate code. Otherwise the end-user does not have a seamless experience and would need to make some manual interaction to reload/refresh the view.

Color Assets should have a light and dark mode, and should also provide high contrast variants of the light and dark mode colors.

Color Assets should be named in a way that conveys the intended use of the color, rather than specific color values.

@kinoroy
Copy link
Member

kinoroy commented Aug 26, 2020

Closing as this was merged to master today.

@kinoroy kinoroy closed this as completed Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants