Skip to content

Commit 17b68dc

Browse files
committed
test: fix simple-keyring
1 parent a20af85 commit 17b68dc

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

packages/keyring-eth-simple/src/simple-keyring.test.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -360,6 +360,7 @@ describe('simple-keyring', function () {
360360
it('returns the expected value if invalid version is given', async function () {
361361
await keyring.deserialize([privKeyHex]);
362362
const signature = await keyring.signTypedData(address, typedData, {
363+
// @ts-expect-error: intentionally passing invalid version
363364
version: 'FOO',
364365
});
365366
expect(signature).toBe(expectedSignature);
@@ -390,7 +391,7 @@ describe('simple-keyring', function () {
390391
it('works via `V1` string', async function () {
391392
await keyring.deserialize([privKeyHex]);
392393
const signature = await keyring.signTypedData(address, typedData, {
393-
version: 'V1',
394+
version: SignTypedDataVersion.V1,
394395
});
395396
expect(signature).toBe(expectedSignature);
396397
const restored = recoverTypedSignature({

packages/keyring-eth-simple/src/simple-keyring.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ export default class SimpleKeyring implements Keyring {
153153
async signTypedData<
154154
Version extends SignTypedDataVersion,
155155
Types extends MessageTypes,
156-
Options extends { version: Version } & KeyringOpt,
156+
Options extends { version?: Version } & KeyringOpt,
157157
>(
158158
address: Hex,
159159
typedData: Version extends 'V1' ? TypedDataV1 : TypedMessage<Types>,

0 commit comments

Comments
 (0)