Skip to content

Commit 888ef2c

Browse files
micaelaemicaelae
committed
fix: unit tests
1 parent 9ca520c commit 888ef2c

File tree

3 files changed

+1
-29
lines changed

3 files changed

+1
-29
lines changed

‎packages/bridge-controller/src/__snapshots__/bridge-controller.test.ts.snap‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -368,13 +368,6 @@ Array [
368368

369369
exports[`BridgeController trackUnifiedSwapBridgeEvent client-side calls should track the QuotesReceived event 1`] = `
370370
Array [
371-
Array [
372-
"NetworkController:getState",
373-
],
374-
Array [
375-
"NetworkController:getNetworkClientById",
376-
"selectedNetworkClientId",
377-
],
378371
Array [
379372
"AccountsController:getAccountByAddress",
380373
"0x123",

‎packages/bridge-controller/src/bridge-controller.sse.test.ts‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ describe('BridgeController SSE', function () {
9292
messengerMock.call.mockReturnValue({
9393
address: '0x123',
9494
provider: jest.fn(),
95-
selectedNetworkClientId: 'selectedNetworkClientId',
9695
currencyRates: {},
9796
marketData: {},
9897
conversionRates: {},
@@ -151,7 +150,6 @@ describe('BridgeController SSE', function () {
151150
expect(startPollingSpy).toHaveBeenCalledTimes(1);
152151
expect(hasSufficientBalanceSpy).toHaveBeenCalledTimes(1);
153152
expect(startPollingSpy).toHaveBeenCalledWith({
154-
networkClientId: 'selectedNetworkClientId',
155153
updatedQuoteRequest: {
156154
...quoteRequest,
157155
insufficientBal: false,
@@ -714,7 +712,6 @@ describe('BridgeController SSE', function () {
714712
expect(startPollingSpy).toHaveBeenCalledTimes(1);
715713
expect(hasSufficientBalanceSpy).toHaveBeenCalledTimes(1);
716714
expect(startPollingSpy).toHaveBeenCalledWith({
717-
networkClientId: 'selectedNetworkClientId',
718715
updatedQuoteRequest: {
719716
...quoteRequest,
720717
insufficientBal: false,

‎packages/bridge-controller/src/bridge-controller.test.ts‎

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,6 @@ describe('BridgeController', function () {
318318
messengerMock.call.mockReturnValue({
319319
address: '0x123',
320320
provider: jest.fn(),
321-
selectedNetworkClientId: 'selectedNetworkClientId',
322321
currencyRates: {},
323322
marketData: {},
324323
conversionRates: {},
@@ -363,7 +362,6 @@ describe('BridgeController', function () {
363362
expect(startPollingSpy).toHaveBeenCalledTimes(1);
364363
expect(hasSufficientBalanceSpy).toHaveBeenCalledTimes(1);
365364
expect(startPollingSpy).toHaveBeenCalledWith({
366-
networkClientId: 'selectedNetworkClientId',
367365
updatedQuoteRequest: {
368366
...quoteRequest,
369367
insufficientBal: false,
@@ -398,7 +396,6 @@ describe('BridgeController', function () {
398396
messengerMock.call.mockReturnValue({
399397
address: '0x123',
400398
provider: jest.fn(),
401-
selectedNetworkClientId: 'selectedNetworkClientId',
402399
currencyRates: {},
403400
marketData: {},
404401
conversionRates: {},
@@ -485,7 +482,6 @@ describe('BridgeController', function () {
485482
expect(startPollingSpy).toHaveBeenCalledTimes(1);
486483
expect(hasSufficientBalanceSpy).toHaveBeenCalledTimes(1);
487484
expect(startPollingSpy).toHaveBeenCalledWith({
488-
networkClientId: 'selectedNetworkClientId',
489485
updatedQuoteRequest: {
490486
...quoteRequest,
491487
insufficientBal: false,
@@ -720,7 +716,6 @@ describe('BridgeController', function () {
720716
}
721717
return {
722718
provider: jest.fn() as never,
723-
selectedNetworkClientId: 'selectedNetworkClientId',
724719
} as never;
725720
},
726721
);
@@ -932,7 +927,6 @@ describe('BridgeController', function () {
932927
messengerMock.call.mockReturnValue({
933928
address: '0x123',
934929
provider: jest.fn(),
935-
selectedNetworkClientId: 'selectedNetworkClientId',
936930
currentCurrency: 'usd',
937931
currencyRates: {},
938932
marketData: {},
@@ -990,7 +984,6 @@ describe('BridgeController', function () {
990984
expect(startPollingSpy).toHaveBeenCalledTimes(1);
991985
expect(hasSufficientBalanceSpy).toHaveBeenCalledTimes(1);
992986
expect(startPollingSpy).toHaveBeenCalledWith({
993-
networkClientId: 'selectedNetworkClientId',
994987
updatedQuoteRequest: {
995988
...quoteRequest,
996989
insufficientBal: true,
@@ -1137,7 +1130,6 @@ describe('BridgeController', function () {
11371130
}
11381131
return {
11391132
provider: jest.fn() as never,
1140-
selectedNetworkClientId: 'selectedNetworkClientId',
11411133
} as never;
11421134
},
11431135
);
@@ -1190,7 +1182,6 @@ describe('BridgeController', function () {
11901182
expect(startPollingSpy).toHaveBeenCalledTimes(1);
11911183
expect(hasSufficientBalanceSpy).not.toHaveBeenCalled();
11921184
expect(startPollingSpy).toHaveBeenCalledWith({
1193-
networkClientId: 'selectedNetworkClientId',
11941185
updatedQuoteRequest: {
11951186
...quoteRequest,
11961187
insufficientBal: true,
@@ -1448,7 +1439,6 @@ describe('BridgeController', function () {
14481439
messengerMock.call.mockReturnValue({
14491440
address: '0x123',
14501441
provider: jest.fn(),
1451-
selectedNetworkClientId: 'selectedNetworkClientId',
14521442
} as never);
14531443

14541444
for (const [index, quote] of quoteResponse.entries()) {
@@ -1506,7 +1496,6 @@ describe('BridgeController', function () {
15061496
expect(startPollingSpy).toHaveBeenCalledTimes(1);
15071497
expect(hasSufficientBalanceSpy).toHaveBeenCalledTimes(1);
15081498
expect(startPollingSpy).toHaveBeenCalledWith({
1509-
networkClientId: 'selectedNetworkClientId',
15101499
updatedQuoteRequest: {
15111500
...quoteRequest,
15121501
insufficientBal: true,
@@ -1717,7 +1706,6 @@ describe('BridgeController', function () {
17171706
messengerMock.call.mockReturnValue({
17181707
address: '0x123',
17191708
provider: jest.fn(),
1720-
selectedNetworkClientId: 'selectedNetworkClientId',
17211709
currencyRates: {},
17221710
marketData: {},
17231711
conversionRates: {},
@@ -1905,7 +1893,6 @@ describe('BridgeController', function () {
19051893
}
19061894
return {
19071895
provider: jest.fn() as never,
1908-
selectedNetworkClientId: 'selectedNetworkClientId',
19091896
} as never;
19101897
},
19111898
);
@@ -2067,7 +2054,6 @@ describe('BridgeController', function () {
20672054

20682055
return {
20692056
provider: jest.fn() as never,
2070-
selectedNetworkClientId: 'selectedNetworkClientId',
20712057
} as never;
20722058
},
20732059
);
@@ -2137,7 +2123,6 @@ describe('BridgeController', function () {
21372123
(): ReturnType<BridgeControllerMessenger['call']> => {
21382124
return {
21392125
provider: jest.fn() as never,
2140-
selectedNetworkClientId: 'selectedNetworkClientId',
21412126
rpcUrl: 'https://mainnet.infura.io/v3/123',
21422127
configuration: {
21432128
chainId: 'eip155:1',
@@ -2149,7 +2134,6 @@ describe('BridgeController', function () {
21492134
(): ReturnType<BridgeControllerMessenger['call']> => {
21502135
return {
21512136
provider: jest.fn() as never,
2152-
selectedNetworkClientId: 'selectedNetworkClientId',
21532137
rpcUrl: 'https://mainnet.infura.io/v3/123',
21542138
configuration: {
21552139
chainId: 'eip155:1',
@@ -2326,7 +2310,6 @@ describe('BridgeController', function () {
23262310
messengerMock.call.mockImplementation(() => {
23272311
return {
23282312
provider: jest.fn() as never,
2329-
selectedNetworkClientId: 'selectedNetworkClientId',
23302313
rpcUrl: 'https://mainnet.infura.io/v3/123',
23312314
configuration: {
23322315
chainId: 'eip155:1',
@@ -2445,7 +2428,7 @@ describe('BridgeController', function () {
24452428
security_warnings: [],
24462429
},
24472430
);
2448-
expect(messengerMock.call).toHaveBeenCalledTimes(2);
2431+
expect(messengerMock.call).toHaveBeenCalledTimes(0);
24492432
expect(trackMetaMetricsFn).toHaveBeenCalledTimes(1);
24502433

24512434
expect(trackMetaMetricsFn.mock.calls).toMatchSnapshot();
@@ -2559,7 +2542,6 @@ describe('BridgeController', function () {
25592542
}
25602543
return {
25612544
provider: jest.fn() as never,
2562-
selectedNetworkClientId: 'selectedNetworkClientId',
25632545
rpcUrl: 'https://mainnet.infura.io/v3/123',
25642546
configuration: {
25652547
chainId: 'eip155:1',

0 commit comments

Comments
 (0)